Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Unified Diff: chrome/browser/chromeos/net/network_portal_detector_impl.h

Issue 99223009: Fixed current OOBE captive portal metrics. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/net/network_portal_detector_impl.h
diff --git a/chrome/browser/chromeos/net/network_portal_detector_impl.h b/chrome/browser/chromeos/net/network_portal_detector_impl.h
index 0b9895fde8aebc5d54feb0f6ffd2bab9cd25d628..642c67e8dd8f66927e49431ec4725ecb583ef9ba 100644
--- a/chrome/browser/chromeos/net/network_portal_detector_impl.h
+++ b/chrome/browser/chromeos/net/network_portal_detector_impl.h
@@ -42,6 +42,12 @@ class NetworkPortalDetectorImpl
public chromeos::NetworkStateHandlerObserver,
public content::NotificationObserver {
public:
+ static const char kDetectionResultHistogram[];
+ static const char kDetectionDurationHistogram[];
+ static const char kShillOnlineHistogram[];
+ static const char kShillPortalHistogram[];
+ static const char kShillOfflineHistogram[];
+
explicit NetworkPortalDetectorImpl(
const scoped_refptr<net::URLRequestContextGetter>& request_context);
virtual ~NetworkPortalDetectorImpl();
@@ -187,6 +193,11 @@ class NetworkPortalDetectorImpl
// * otherwise, timeout equals to |attempt_count_| * kBaseRequestTimeoutSec
int GetRequestTimeoutSec() const;
+ // Record detection stats such as detection duration and detection
+ // result in UMA.
+ void RecordDetectionStats(const NetworkState* network,
+ CaptivePortalStatus status);
+
// Name of the default network.
std::string default_network_name_;
« no previous file with comments | « chrome/browser/chromeos/net/network_portal_detector.cc ('k') | chrome/browser/chromeos/net/network_portal_detector_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698