Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 992203004: Fix bug in Valgrind flags config. (Closed)

Created:
5 years, 9 months ago by mtklein_C
Modified:
5 years, 9 months ago
Reviewers:
borenet, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix bug in Valgrind flags config. 'GPU' is in 'Test-Ubuntu14-GCE-NoGPU-x86_64-Release-Valgrind_CPU' too. This means we're building it in no-GPU mode, and running it in no-CPU mode. At least it finishes quite quickly this way (~10 seconds). BUG=skia: Committed: https://skia.googlesource.com/skia/+/7e78f3d0e7ba7cf08080d5bf978c50fd5a9f6127

Patch Set 1 #

Patch Set 2 : nanobench too #

Total comments: 2

Patch Set 3 : Valgrind_ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M tools/dm_flags.json View 4 chunks +4 lines, -4 lines 0 comments Download
M tools/dm_flags.py View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M tools/nanobench_flags.json View 1 3 chunks +4 lines, -4 lines 0 comments Download
M tools/nanobench_flags.py View 1 2 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
mtklein_C
5 years, 9 months ago (2015-03-10 13:59:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/992203004/1
5 years, 9 months ago (2015-03-10 13:59:53 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-10 13:59:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/992203004/1
5 years, 9 months ago (2015-03-10 14:03:53 UTC) #8
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-10 14:03:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/992203004/20001
5 years, 9 months ago (2015-03-10 14:12:53 UTC) #12
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-10 14:12:53 UTC) #13
borenet
Whoops, thanks for the fix. LGTM https://codereview.chromium.org/992203004/diff/20001/tools/dm_flags.py File tools/dm_flags.py (right): https://codereview.chromium.org/992203004/diff/20001/tools/dm_flags.py#newcode64 tools/dm_flags.py:64: if '_GPU' in ...
5 years, 9 months ago (2015-03-10 14:50:04 UTC) #15
mtklein
https://codereview.chromium.org/992203004/diff/20001/tools/dm_flags.py File tools/dm_flags.py (right): https://codereview.chromium.org/992203004/diff/20001/tools/dm_flags.py#newcode64 tools/dm_flags.py:64: if '_GPU' in bot: On 2015/03/10 14:50:04, borenet wrote: ...
5 years, 9 months ago (2015-03-10 14:58:02 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/992203004/40001
5 years, 9 months ago (2015-03-10 14:58:04 UTC) #19
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 15:03:30 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/7e78f3d0e7ba7cf08080d5bf978c50fd5a9f6127

Powered by Google App Engine
This is Rietveld 408576698