Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: tools/nanobench_flags.py

Issue 992203004: Fix bug in Valgrind flags config. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Valgrind_ Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/nanobench_flags.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/nanobench_flags.py
diff --git a/tools/nanobench_flags.py b/tools/nanobench_flags.py
index cec48a1809e26a96e10e3c3a721eb5f66300fce1..81cd8cebe096aff272013afc5ff8336927252908 100755
--- a/tools/nanobench_flags.py
+++ b/tools/nanobench_flags.py
@@ -40,9 +40,9 @@ def get_args(bot):
# Don't care about Valgrind performance.
args.extend(['--loops', '1'])
args.extend(['--samples', '1'])
- if 'GPU' in bot:
+ if 'Valgrind_GPU' in bot:
args.append('--nocpu')
- elif 'CPU' in bot:
+ elif 'Valgrind_CPU' in bot:
args.append('--nogpu')
match = []
@@ -58,7 +58,7 @@ def get_args(bot):
if match:
args.append('--match')
args.extend(match)
-
+
if ('GalaxyS3' in bot or
'GalaxyS4' in bot):
@@ -73,7 +73,7 @@ def self_test():
cases = [
'Perf-Android-GalaxyS3-Mali400-Arm7-Release',
'Perf-Android-Nexus7-Tegra3-Arm7-Release',
- 'Test-Ubuntu12-ShuttleA-GTX550Ti-x86_64-Release-Valgrind_CPU',
+ 'Test-Ubuntu14-GCE-NoGPU-x86_64-Release-Valgrind_CPU',
'Test-Ubuntu12-ShuttleA-GTX550Ti-x86_64-Release-Valgrind_GPU',
'Test-Win7-ShuttleA-HD2000-x86-Debug-ANGLE',
]
« no previous file with comments | « tools/nanobench_flags.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698