Issue 992003003: Revert of Do not cache resource metadata if the source code size is small.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 992003003: Revert of Do not cache resource metadata if the source code size is small. (Closed)

Created:
5 years, 9 months ago by jbroman

Modified:
5 years, 9 months ago

Reviewers:
jochen (gone - plz use gerrit), vogelheim, Yang

CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, vivekg

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Revert of Do not cache resource metadata if the source code size is small. (patchset #1 id:1 of https://codereview.chromium.org/988303003/) Reason for revert: Causes content_browsertests:ServiceWorkerVersionBrowserV8CacheTest.Restart to time out. This is blocking the Blink roll: https://codereview.chromium.org/986373002/ Original issue's description: > Do not cache resource metadata if the source code size is small. > > For small source code, parsing/compiling may be faster than > deserializing. > > R=jochen@chromium.org, vogelheim@chromium.org > BUG=chromium:399580 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191554 TBR=jochen@chromium.org,vogelheim@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:399580 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191581

Created: 5 years, 9 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	Source/bindings/core/v8/V8ScriptRunner.cpp	View		2 chunks	+5 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

jbroman

Created Revert of Do not cache resource metadata if the source code size is small.

5 years, 9 months ago (2015-03-09 19:59:56 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/992003003/1

5 years, 9 months ago (2015-03-09 20:00:58 UTC) #2

commit-bot: I haz the power

5 years, 9 months ago (2015-03-09 20:01:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191581