Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 991893003: Remove frame pointer from StackHandler. (Closed)

Created:
5 years, 9 months ago by Michael Starzinger
Modified:
5 years, 9 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_stack-handler-1
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove frame pointer from StackHandler. This reduces the size of the StackHandler by yet another word. We no longer need to keep track of the frame pointer, as the stack walk will be able to recalculate it. R=yangguo@chromium.org Committed: https://crrev.com/36e69a916f2a88664887d2b62f0eaf8400edb182 Cr-Commit-Position: refs/heads/master@{#27115}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -96 lines) Patch
M src/arm/frames-arm.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M src/arm64/frames-arm64.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M src/frames.h View 3 chunks +1 line, -4 lines 0 comments Download
M src/frames.cc View 2 chunks +10 lines, -15 lines 0 comments Download
M src/frames-inl.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/ia32/frames-ia32.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/frames-mips.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/mips64/frames-mips64.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/ppc/frames-ppc.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/x64/frames-x64.h View 1 chunk +0 lines, -9 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +2 lines, -9 lines 0 comments Download
M src/x87/frames-x87.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Michael Starzinger
5 years, 9 months ago (2015-03-09 18:23:09 UTC) #1
Yang
LGTM, but the optional ports are incomplete, right? Changes to macro-assembler-* are missing for PPC, ...
5 years, 9 months ago (2015-03-10 12:00:05 UTC) #2
Michael Starzinger
Yes, I only ported to ARM, ARM64, ia32 and x64.
5 years, 9 months ago (2015-03-10 12:03:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/991893003/1
5 years, 9 months ago (2015-03-10 15:45:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-10 15:56:20 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 15:56:34 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/36e69a916f2a88664887d2b62f0eaf8400edb182
Cr-Commit-Position: refs/heads/master@{#27115}

Powered by Google App Engine
This is Rietveld 408576698