Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issue 991853002: Remove lazy sweeping of new space and corresponding complicated pointer updating logic. (Closed)

Created:
5 years, 9 months ago by Hannes Payer (out of office)
Modified:
5 years, 9 months ago
Reviewers:
ulan, Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove lazy sweeping of new space and corresponding complicated pointer updating logic. We can do that now since we have the invariant that the store buffer always has valid slots after marking. BUG= Committed: https://crrev.com/02ce445394413cd65a8888078bb86fc90d90e3ff Cr-Commit-Position: refs/heads/master@{#27105}

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -68 lines) Patch
M src/heap/mark-compact.cc View 1 2 2 chunks +10 lines, -15 lines 0 comments Download
M src/heap/store-buffer.h View 1 2 4 chunks +4 lines, -16 lines 0 comments Download
M src/heap/store-buffer.cc View 1 2 10 chunks +11 lines, -29 lines 0 comments Download
M src/heap/store-buffer-inl.h View 1 2 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Hannes Payer (out of office)
5 years, 9 months ago (2015-03-09 13:33:21 UTC) #2
Hannes Payer (out of office)
https://codereview.chromium.org/991853002/diff/20001/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/991853002/diff/20001/src/heap/mark-compact.cc#newcode3013 src/heap/mark-compact.cc:3013: // Ignore these pointers here. Note that we could ...
5 years, 9 months ago (2015-03-09 20:40:00 UTC) #3
ulan
lgtm, nice! https://codereview.chromium.org/991853002/diff/20001/src/heap/store-buffer.cc File src/heap/store-buffer.cc (left): https://codereview.chromium.org/991853002/diff/20001/src/heap/store-buffer.cc#oldcode395 src/heap/store-buffer.cc:395: if (clear_maps) ClearDeadObject(heap_object); We can remove the ...
5 years, 9 months ago (2015-03-10 10:37:33 UTC) #5
Hannes Payer (out of office)
https://codereview.chromium.org/991853002/diff/20001/src/heap/store-buffer.cc File src/heap/store-buffer.cc (left): https://codereview.chromium.org/991853002/diff/20001/src/heap/store-buffer.cc#oldcode395 src/heap/store-buffer.cc:395: if (clear_maps) ClearDeadObject(heap_object); On 2015/03/10 10:37:32, ulan wrote: > ...
5 years, 9 months ago (2015-03-10 13:07:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/991853002/40001
5 years, 9 months ago (2015-03-10 13:07:22 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-10 13:42:19 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 13:42:32 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/02ce445394413cd65a8888078bb86fc90d90e3ff
Cr-Commit-Position: refs/heads/master@{#27105}

Powered by Google App Engine
This is Rietveld 408576698