Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 991833002: Simplify promise event on throw handling. (Closed)

Created:
5 years, 9 months ago by Yang
Modified:
5 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Simplify promise event on throw handling. R=mstarzinger@chromium.org Committed: https://crrev.com/9dedcc3dfcac1b88f61a85f8045a869702f36633 Cr-Commit-Position: refs/heads/master@{#27074}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -68 lines) Patch
M src/isolate.cc View 1 chunk +3 lines, -8 lines 0 comments Download
A + test/mjsunit/es6/debug-promises/resolve-after-aborted-try-finally.js View 1 chunk +17 lines, -21 lines 0 comments Download
A + test/mjsunit/es6/debug-promises/resolve-after-try-catch.js View 1 chunk +12 lines, -19 lines 0 comments Download
A + test/mjsunit/es6/debug-promises/rethrow-in-try-finally.js View 1 chunk +14 lines, -20 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
5 years, 9 months ago (2015-03-09 12:18:29 UTC) #1
Michael Starzinger
LGTM.
5 years, 9 months ago (2015-03-09 12:53:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/991833002/1
5 years, 9 months ago (2015-03-09 13:06:59 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 13:41:47 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 13:42:06 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9dedcc3dfcac1b88f61a85f8045a869702f36633
Cr-Commit-Position: refs/heads/master@{#27074}

Powered by Google App Engine
This is Rietveld 408576698