Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: test/mjsunit/es6/debug-promises/rethrow-in-try-finally.js

Issue 991833002: Simplify promise event on throw handling. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/mjsunit/es6/debug-promises/resolve-after-try-catch.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/es6/debug-promises/rethrow-in-try-finally.js
diff --git a/test/mjsunit/es6/debug-promises/throw-caught-uncaught.js b/test/mjsunit/es6/debug-promises/rethrow-in-try-finally.js
similarity index 54%
copy from test/mjsunit/es6/debug-promises/throw-caught-uncaught.js
copy to test/mjsunit/es6/debug-promises/rethrow-in-try-finally.js
index 0ad9ce48a22c78fc431f693c22e2629c60759cef..b1e2ff98e1a0b58eed9c11be9e05015d31ab451d 100644
--- a/test/mjsunit/es6/debug-promises/throw-caught-uncaught.js
+++ b/test/mjsunit/es6/debug-promises/rethrow-in-try-finally.js
@@ -4,33 +4,27 @@
// Flags: --expose-debug-as debug --allow-natives-syntax
-// Test debug events when we only listen to uncaught exceptions and
+// Test debug events when we listen to all exceptions and
// there is a catch handler for the exception thrown in a Promise.
-// We expect no debug event to be triggered.
+// We expect a normal Exception debug event to be triggered.
Debug = debug.Debug;
-var p = new Promise(function(resolve, reject) {
- resolve();
-});
+var events = [];
-var q = p.chain(
- function() {
- throw new Error("caught throw");
- });
+function listener(event, exec_state, event_data, data) {
+ if (event == Debug.DebugEvent.PromiseEvent) events.push(event_data.status());
+}
-q.catch(
- function(e) {
- assertEquals("caught throw", e.message);
- });
+Debug.setListener(listener);
-function listener(event, exec_state, event_data, data) {
+var p = new Promise(function(resolve, reject) {
try {
- assertTrue(event != Debug.DebugEvent.Exception);
- } catch (e) {
- %AbortJS(e + "\n" + e.stack);
+ throw new Error("reject");
+ } finally {
+ // Implicit rethrow.
}
-}
+ resolve();
+});
-Debug.setBreakOnUncaughtException();
-Debug.setListener(listener);
+assertEquals([0 /* create */, -1 /* rethrown */], events);
« no previous file with comments | « test/mjsunit/es6/debug-promises/resolve-after-try-catch.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698