Use constant types to represent the fixed right arg of a MOD.

Use constant types to represent the fixed right arg of a MOD.

R=mvstanton@chromium.org, svenpanne@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=18228

[Benedikt Meurer, 2013-12-02 14:27:46]

PTAL

[mvstanton, 2013-12-03 10:34:12]

Nice closing of a TODO :).
One question inline...

https://codereview.chromium.org/99173002/diff/20001/src/ic.cc
File src/ic.cc (right):

https://codereview.chromium.org/99173002/diff/20001/src/ic.cc#newcode2332
src/ic.cc:2332: ASSERT(Smi::IsValid(fixed_right_arg_.value));
How are you sure that fixed_right_arg will have a value only if it's a SMI?

[Benedikt Meurer, 2013-12-03 10:36:39]

https://codereview.chromium.org/99173002/diff/20001/src/ic.cc
File src/ic.cc (right):

https://codereview.chromium.org/99173002/diff/20001/src/ic.cc#newcode2332
src/ic.cc:2332: ASSERT(Smi::IsValid(fixed_right_arg_.value));
On 2013/12/03 10:34:12, mvstanton wrote:
> How are you sure that fixed_right_arg will have a value only if it's a SMI?

Because we have only 4 bits to encode the log2 of the fixed right arg, so the
max value is 2^(2^4), which is always a SMI.

[mvstanton, 2013-12-03 10:49:02]

Cool, add a comment with that explanation at this location and then...

lgtm.

[Benedikt Meurer, 2013-12-03 10:52:09]

Committed patchset #3 manually as r18228 (presubmit successful).