Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: src/code-stubs-hydrogen.cc

Issue 99173002: Use constant types to represent the fixed right arg of a MOD. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Add comment. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast.h ('k') | src/hydrogen.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs-hydrogen.cc
diff --git a/src/code-stubs-hydrogen.cc b/src/code-stubs-hydrogen.cc
index e52ec65c4b7632ac81cb082bfcd5d727cce3a574..fac4cf3edcf7ea6770b837b3ad1d94d63a7f4ea4 100644
--- a/src/code-stubs-hydrogen.cc
+++ b/src/code-stubs-hydrogen.cc
@@ -922,14 +922,13 @@ HValue* CodeStubGraphBuilder<BinaryOpICStub>::BuildCodeInitializedStub() {
Push(BuildBinaryOperation(
state.op(), left, right,
handle(Type::String(), isolate()), right_type,
- result_type, state.fixed_right_arg()));
+ result_type));
}
if_leftisstring.Else();
{
Push(BuildBinaryOperation(
state.op(), left, right,
- left_type, right_type, result_type,
- state.fixed_right_arg()));
+ left_type, right_type, result_type));
}
if_leftisstring.End();
result = Pop();
@@ -941,14 +940,13 @@ HValue* CodeStubGraphBuilder<BinaryOpICStub>::BuildCodeInitializedStub() {
Push(BuildBinaryOperation(
state.op(), left, right,
left_type, handle(Type::String(), isolate()),
- result_type, state.fixed_right_arg()));
+ result_type));
}
if_rightisstring.Else();
{
Push(BuildBinaryOperation(
state.op(), left, right,
- left_type, right_type, result_type,
- state.fixed_right_arg()));
+ left_type, right_type, result_type));
}
if_rightisstring.End();
result = Pop();
@@ -956,8 +954,7 @@ HValue* CodeStubGraphBuilder<BinaryOpICStub>::BuildCodeInitializedStub() {
} else {
result = BuildBinaryOperation(
state.op(), left, right,
- left_type, right_type, result_type,
- state.fixed_right_arg());
+ left_type, right_type, result_type);
}
// If we encounter a generic argument, the number conversion is
« no previous file with comments | « src/ast.h ('k') | src/hydrogen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698