Issue 99153012: Exclude dev tools bounds from views dialog hosting bounds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 99153012: Exclude dev tools bounds from views dialog hosting bounds. (Closed)

Created:
6 years, 11 months ago by msw

Modified:
6 years, 11 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina, Mike Wittman, Rune Fevang, sky

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Exclude dev tools bounds from views dialog hosting bounds. Add BrowserViewLayoutDelegate::GetContentsWebView helper. (avoids direct BrowserView usage by BrowserViewLayout) Consider the latest dialog position *AND* size on updates. (previously, the maximum dialog size was incorrectly ignored) Only use the contents WebView bounds, not its container. (the container also includes the dev tools view bounds) Minor BrowserViewLayout cleanup and refactoring. BUG=328798 TEST=Collected Cookies and Print Preview dialogs resize as the web tools height is manually adjusted. R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243168

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -41 lines)			Patch
M	chrome/browser/ui/views/frame/browser_view.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view_layout.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view_layout.cc	View	1	3 chunks	+22 lines, -36 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view_layout_delegate.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view_layout_unittest.cc	View	1 2	4 chunks	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/99153012/130001

6 years, 11 months ago (2014-01-06 18:12:42 UTC) #3

Message was sent while issue was closed.

Change committed as 243168

Expand Messages | Collapse Messages

Issue 99153012: Exclude dev tools bounds from views dialog hosting bounds. (Closed)

Description

Patch Set 1 #

Patch Set 2 : NotifyPositionRequiresUpdate on any bounds changes; cleanup. #

Patch Set 3 : Hook up the unit test contents webview. #

Messages