Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6945)

Unified Diff: chrome/browser/ui/views/frame/browser_view_layout_unittest.cc

Issue 99153012: Exclude dev tools bounds from views dialog hosting bounds. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Hook up the unit test contents webview. Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/frame/browser_view_layout_delegate.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/frame/browser_view_layout_unittest.cc
diff --git a/chrome/browser/ui/views/frame/browser_view_layout_unittest.cc b/chrome/browser/ui/views/frame/browser_view_layout_unittest.cc
index 5e7c9b2566da48ddc1af190dd70a2ea343d5640d..461a40e66fc51543ec185d2a45cea373de573ae7 100644
--- a/chrome/browser/ui/views/frame/browser_view_layout_unittest.cc
+++ b/chrome/browser/ui/views/frame/browser_view_layout_unittest.cc
@@ -15,8 +15,9 @@
class MockBrowserViewLayoutDelegate : public BrowserViewLayoutDelegate {
public:
- MockBrowserViewLayoutDelegate()
- : tab_strip_visible_(true),
+ explicit MockBrowserViewLayoutDelegate(views::View* contents_web_view)
+ : contents_web_view_(contents_web_view),
+ tab_strip_visible_(true),
toolbar_visible_(true),
bookmark_bar_visible_(true),
download_shelf_needs_layout_(false) {
@@ -37,6 +38,9 @@ class MockBrowserViewLayoutDelegate : public BrowserViewLayoutDelegate {
}
// BrowserViewLayout::Delegate overrides:
+ virtual views::View* GetContentsWebView() const OVERRIDE {
+ return contents_web_view_;
+ }
virtual views::View* GetWindowSwitcherButton() const OVERRIDE {
// TODO(jamescook): Add a test for Windows that exercises the layout for
// this button.
@@ -69,6 +73,7 @@ class MockBrowserViewLayoutDelegate : public BrowserViewLayoutDelegate {
}
private:
+ views::View* contents_web_view_;
bool tab_strip_visible_;
bool toolbar_visible_;
bool bookmark_bar_visible_;
@@ -182,7 +187,7 @@ class BrowserViewLayoutTest : public BrowserWithTestWindowTest {
// TODO(jamescook): Attach |layout_| to |root_view_|?
layout_.reset(new BrowserViewLayout);
- delegate_ = new MockBrowserViewLayoutDelegate;
+ delegate_ = new MockBrowserViewLayoutDelegate(contents_web_view_);
layout_->Init(delegate_,
browser(),
NULL, // BrowserView.
« no previous file with comments | « chrome/browser/ui/views/frame/browser_view_layout_delegate.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698