Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 991373002: Move IsPointerConvertible<T, JSONValue> specialization out of TypeTraits.h (Closed)

Created:
5 years, 9 months ago by sof
Modified:
5 years, 9 months ago
Reviewers:
tkent, haraken
CC:
blink-reviews, blink-reviews-wtf_chromium.org, aandrey+blink_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move IsPointerConvertible<T, JSONValue> specialization out of TypeTraits.h Preferable to have it next to the type's declaration. R=tkent,haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191688

Patch Set 1 #

Patch Set 2 : blind android compile fix.. #

Patch Set 3 : move specialization up before its first instantiation #

Patch Set 4 : clarify why this specialization is needed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -11 lines) Patch
M Source/platform/JSONValues.h View 1 2 3 2 chunks +31 lines, -1 line 0 comments Download
M Source/wtf/TypeTraits.h View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
sof
please take a look. Avoids having any specializations to consider when resolving IsPointerConvertible<> / EnableIf<> ...
5 years, 9 months ago (2015-03-10 15:46:04 UTC) #2
haraken
LGTM
5 years, 9 months ago (2015-03-10 15:57:13 UTC) #3
tkent
lgtm if JSONValue.h is included in the code using IsPointerConvertible<T, JSONValue>.
5 years, 9 months ago (2015-03-11 00:32:50 UTC) #4
sof
On 2015/03/11 00:32:50, tkent wrote: > lgtm if JSONValue.h is included in the code using ...
5 years, 9 months ago (2015-03-11 06:24:44 UTC) #5
sof
On 2015/03/11 06:24:44, sof wrote: > On 2015/03/11 00:32:50, tkent wrote: > > lgtm if ...
5 years, 9 months ago (2015-03-11 08:25:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/991373002/60001
5 years, 9 months ago (2015-03-11 09:48:37 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 10:24:50 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191688

Powered by Google App Engine
This is Rietveld 408576698