Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Unified Diff: Source/wtf/TypeTraits.h

Issue 991373002: Move IsPointerConvertible<T, JSONValue> specialization out of TypeTraits.h (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: clarify why this specialization is needed Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/JSONValues.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/wtf/TypeTraits.h
diff --git a/Source/wtf/TypeTraits.h b/Source/wtf/TypeTraits.h
index 3dfcc31793fa43ccdf0d492016d3aa57eb78323d..4946ef5d39e9f631a72c43393362b7804fd0f0c2 100644
--- a/Source/wtf/TypeTraits.h
+++ b/Source/wtf/TypeTraits.h
@@ -302,22 +302,12 @@ namespace WTF {
namespace blink {
-class JSONValue;
class Visitor;
} // namespace blink
namespace WTF {
- // FIXME: Disable pointer conversion checking against JSONValue.
- // The current CodeGeneratorInspector.py generates code which upcasts to JSONValue from undefined types.
- template<typename From> class IsPointerConvertible<From, blink::JSONValue> {
- public:
- enum {
- Value = true
- };
- };
-
template<typename T>
class NeedsTracing {
typedef char YesType;
« no previous file with comments | « Source/platform/JSONValues.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698