Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 99103004: Revert "Revert 237280 "Remove TraceController"" (Closed)

Created:
7 years ago by Xianzhu
Modified:
7 years ago
Reviewers:
CC:
chromium-reviews, paulirish+reviews_chromium.org, vsevik, jam, aandrey+blink_chromium.org, yurys, joi+watch-content_chromium.org, dsinclair+watch_chromium.org, robertshield, devtools-reviews_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert "Revert 237280 "Remove TraceController"" This reverts commit 6aa58b8599840160df945afa89e7482d14d1c4d4. Fixed double-close issue when ending recording. > Revert 237280 "Remove TraceController" > > Seems to have broken trace-based telemetry benchmarks on android. > > BUG=323749 > > > Remove TraceController > > > > TraceController is obsoleted by TracingController. > > Changed all remaining clients to use TracingController. > > > > BUG=none > > > > Review URL: https://codereview.chromium.org/67683003 > > TBR=wangxianzhu@chromium.org > > Review URL: https://codereview.chromium.org/89753004 > > git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237452 0039d316-1c4b-4281-b951-d872f2087c98 TBR=wangxianzhu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238234

Patch Set 1 #

Patch Set 2 : Fix close issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+547 lines, -1638 lines) Patch
M base/debug/trace_event_impl.h View 8 chunks +11 lines, -56 lines 0 comments Download
M base/debug/trace_event_impl.cc View 24 chunks +76 lines, -140 lines 0 comments Download
M base/debug/trace_event_unittest.cc View 11 chunks +13 lines, -35 lines 0 comments Download
M chrome/browser/automation/automation_provider.h View 5 chunks +3 lines, -19 lines 0 comments Download
M chrome/browser/automation/automation_provider.cc View 5 chunks +16 lines, -42 lines 0 comments Download
M chrome/browser/feedback/feedback_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/feedback/feedback_util.cc View 1 chunk +15 lines, -6 lines 0 comments Download
M chrome/browser/feedback/tracing_manager.h View 3 chunks +10 lines, -12 lines 0 comments Download
M chrome/browser/feedback/tracing_manager.cc View 6 chunks +15 lines, -24 lines 0 comments Download
M chrome/common/automation_messages_internal.h View 1 chunk +1 line, -9 lines 0 comments Download
M chrome/test/automation/automation_proxy.cc View 2 chunks +6 lines, -24 lines 0 comments Download
M chrome/test/base/tracing.cc View 6 chunks +50 lines, -30 lines 0 comments Download
M components/tracing/child_trace_message_filter.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/tracing/child_trace_message_filter.cc View 3 chunks +13 lines, -16 lines 0 comments Download
M components/tracing/tracing_messages.h View 3 chunks +4 lines, -5 lines 0 comments Download
M content/browser/android/tracing_controller_android.h View 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/android/tracing_controller_android.cc View 3 chunks +21 lines, -46 lines 0 comments Download
M content/browser/devtools/devtools_tracing_handler.h View 1 chunk +13 lines, -13 lines 0 comments Download
M content/browser/devtools/devtools_tracing_handler.cc View 5 chunks +80 lines, -32 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
D content/browser/tracing/trace_controller_impl.h View 1 chunk +0 lines, -105 lines 0 comments Download
D content/browser/tracing/trace_controller_impl.cc View 1 chunk +0 lines, -371 lines 0 comments Download
M content/browser/tracing/trace_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tracing/trace_message_filter.cc View 8 chunks +8 lines, -15 lines 0 comments Download
D content/browser/tracing/trace_subscriber_stdio.h View 1 chunk +0 lines, -57 lines 0 comments Download
D content/browser/tracing/trace_subscriber_stdio.cc View 1 chunk +0 lines, -201 lines 0 comments Download
D content/browser/tracing/trace_subscriber_stdio_unittest.cc View 1 chunk +0 lines, -132 lines 0 comments Download
M content/browser/tracing/tracing_controller_browsertest.cc View 6 chunks +7 lines, -8 lines 0 comments Download
M content/browser/tracing/tracing_controller_impl.h View 5 chunks +27 lines, -12 lines 0 comments Download
M content/browser/tracing/tracing_controller_impl.cc View 1 16 chunks +123 lines, -49 lines 0 comments Download
M content/browser/tracing/tracing_ui.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +0 lines, -6 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D content/public/browser/trace_controller.h View 1 chunk +0 lines, -107 lines 0 comments Download
D content/public/browser/trace_subscriber.h View 1 chunk +0 lines, -43 lines 0 comments Download
M content/public/browser/tracing_controller.h View 9 chunks +25 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/99103004/20001
7 years ago (2013-12-02 20:35:53 UTC) #1
commit-bot: I haz the power
Change committed as 238234
7 years ago (2013-12-02 23:43:58 UTC) #2
Xianzhu
7 years ago (2013-12-03 17:29:53 UTC) #3
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/101543004/ by wangxianzhu@chromium.org.

The reason for reverting is: Bug 323749 still unresolved.

Powered by Google App Engine
This is Rietveld 408576698