Issue 89753004: Revert 237280 "Remove TraceController"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 89753004: Revert 237280 "Remove TraceController" (Closed)

Created:
7 years ago by tonyg

Modified:
7 years ago

Reviewers:
Xianzhu

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 237280 "Remove TraceController" Seems to have broken trace-based telemetry benchmarks on android. BUG=323749 > Remove TraceController > > TraceController is obsoleted by TracingController. > Changed all remaining clients to use TracingController. > > BUG=none > > Review URL: https://codereview.chromium.org/67683003 TBR=wangxianzhu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237452

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+615 lines, -538 lines)			Patch
M	trunk/src/base/debug/trace_event_impl.h	View	8 chunks	+56 lines, -11 lines	0 comments	Download
M	trunk/src/base/debug/trace_event_impl.cc	View	24 chunks	+140 lines, -76 lines	0 comments	Download
M	trunk/src/base/debug/trace_event_unittest.cc	View	11 chunks	+35 lines, -13 lines	0 comments	Download
M	trunk/src/chrome/browser/automation/automation_provider.h	View	5 chunks	+19 lines, -3 lines	0 comments	Download
M	trunk/src/chrome/browser/automation/automation_provider.cc	View	5 chunks	+42 lines, -16 lines	0 comments	Download
M	trunk/src/chrome/browser/feedback/feedback_util.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/chrome/browser/feedback/feedback_util.cc	View	1 chunk	+6 lines, -15 lines	0 comments	Download
M	trunk/src/chrome/browser/feedback/tracing_manager.h	View	3 chunks	+12 lines, -10 lines	0 comments	Download
M	trunk/src/chrome/browser/feedback/tracing_manager.cc	View	6 chunks	+24 lines, -15 lines	0 comments	Download
M	trunk/src/chrome/common/automation_messages_internal.h	View	1 chunk	+9 lines, -1 line	0 comments	Download
M	trunk/src/chrome/test/automation/automation_proxy.cc	View	2 chunks	+24 lines, -6 lines	0 comments	Download
M	trunk/src/chrome/test/base/tracing.cc	View	6 chunks	+30 lines, -50 lines	0 comments	Download
M	trunk/src/components/tracing/child_trace_message_filter.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	trunk/src/components/tracing/child_trace_message_filter.cc	View	3 chunks	+16 lines, -13 lines	0 comments	Download
M	trunk/src/components/tracing/tracing_messages.h	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	trunk/src/content/browser/android/tracing_controller_android.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	trunk/src/content/browser/android/tracing_controller_android.cc	View	3 chunks	+46 lines, -21 lines	0 comments	Download
M	trunk/src/content/browser/devtools/devtools_tracing_handler.h	View	1 chunk	+13 lines, -13 lines	0 comments	Download
M	trunk/src/content/browser/devtools/devtools_tracing_handler.cc	View	5 chunks	+32 lines, -80 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/render_process_host_impl.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
A +	trunk/src/content/browser/tracing/trace_controller_impl.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/content/browser/tracing/trace_controller_impl.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	trunk/src/content/browser/tracing/trace_message_filter.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/content/browser/tracing/trace_message_filter.cc	View	8 chunks	+15 lines, -8 lines	0 comments	Download
A +	trunk/src/content/browser/tracing/trace_subscriber_stdio.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/content/browser/tracing/trace_subscriber_stdio.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/content/browser/tracing/trace_subscriber_stdio_unittest.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	trunk/src/content/browser/tracing/tracing_controller_browsertest.cc	View	6 chunks	+8 lines, -7 lines	0 comments	Download
M	trunk/src/content/browser/tracing/tracing_controller_impl.h	View	5 chunks	+12 lines, -27 lines	0 comments	Download
M	trunk/src/content/browser/tracing/tracing_controller_impl.cc	View	14 chunks	+49 lines, -121 lines	0 comments	Download
M	trunk/src/content/browser/tracing/tracing_ui.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	trunk/src/content/content_browser.gypi	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	trunk/src/content/content_tests.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
A +	trunk/src/content/public/browser/trace_controller.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/content/public/browser/trace_subscriber.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	trunk/src/content/public/browser/tracing_controller.h	View	9 chunks	+10 lines, -25 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r237452.

Expand Messages | Collapse Messages