Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 990983003: Fixing analysis_canvas treatment of save layers with src xfermode (Closed)

Created:
5 years, 9 months ago by Justin Novosad
Modified:
5 years, 9 months ago
Reviewers:
f(malita), reed2, reed1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing analysis_canvas treatment of save layers with src xfermode Code in AnalysisCanvas::willSaveLayer was treating the case of layers composited with kSrc_Mode as if they did not affect the destination, when in fact it is kDst_Mode that does not affect the destination. As a result of this error, the compositor was culling layers that contained opaque canvas elements, which are composited with 'src' for performance. BUG=464694 TEST=skia_unittest AnalysisCanvasTest.SaveLayerWithXfermode Committed: https://crrev.com/9b40df656981fa2e9eaf158f22016b0d566bdaa8 Cr-Commit-Position: refs/heads/master@{#319719}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -1 line) Patch
M skia/ext/analysis_canvas.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/analysis_canvas_unittest.cc View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Justin Novosad
5 years, 9 months ago (2015-03-09 18:38:02 UTC) #2
reed1
lgtm
5 years, 9 months ago (2015-03-09 19:00:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/990983003/1
5 years, 9 months ago (2015-03-09 19:02:11 UTC) #6
f(malita)
lgtm++
5 years, 9 months ago (2015-03-09 19:03:09 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 20:14:20 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 20:14:49 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b40df656981fa2e9eaf158f22016b0d566bdaa8
Cr-Commit-Position: refs/heads/master@{#319719}

Powered by Google App Engine
This is Rietveld 408576698