skia/ext/analysis_canvas.cc - Issue 990983003: Fixing analysis_canvas treatment of save layers with src xfermode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: skia/ext/analysis_canvas.cc

Issue 990983003: Fixing analysis_canvas treatment of save layers with src xfermode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: skia/ext/analysis_canvas.cc

diff --git a/skia/ext/analysis_canvas.cc b/skia/ext/analysis_canvas.cc

index fe447c763a48fdc59522e820bea659ac04e707ef..0ff16602d9cc1a8787c2f94a40f5bb7584c5fab7 100644

--- a/skia/ext/analysis_canvas.cc

+++ b/skia/ext/analysis_canvas.cc

@@ -418,7 +418,7 @@ SkCanvas::SaveLayerStrategy AnalysisCanvas::willSaveLayer(

SkXfermode::Mode xfermode = SkXfermode::kSrc_Mode;

if (paint)

SkXfermode::AsMode(paint->getXfermode(), &xfermode);

- if (xfermode != SkXfermode::kSrc_Mode) {

+ if (xfermode != SkXfermode::kDst_Mode) {

if (force_not_transparent_stack_level_ == kNoLayer) {

force_not_transparent_stack_level_ = saved_stack_size_;

SetForceNotTransparent(true);

« no previous file with comments | « no previous file | skia/ext/analysis_canvas_unittest.cc » ('j') | no next file with comments »