Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Unified Diff: Source/core/html/track/vtt/VTTCue.cpp

Issue 99083002: WIP: Migrate generated bindings to new ExceptionState constructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: MessagePort. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/track/vtt/VTTCue.cpp
diff --git a/Source/core/html/track/vtt/VTTCue.cpp b/Source/core/html/track/vtt/VTTCue.cpp
index dd9f6e84b738c66249ff4bcd4aac7c5cf79515bc..b3ac58ce8dbf33c2f9ef40f37d88456c0ec57c60 100644
--- a/Source/core/html/track/vtt/VTTCue.cpp
+++ b/Source/core/html/track/vtt/VTTCue.cpp
@@ -113,12 +113,12 @@ static const String& verticalGrowingRightKeyword()
return verticallr;
}
-static bool isInvalidPercentage(double value, const char* method, ExceptionState& exceptionState)
+static bool isInvalidPercentage(double value, ExceptionState& exceptionState)
{
- if (TextTrackCue::isInfiniteOrNonNumber(value, method, exceptionState))
+ if (TextTrackCue::isInfiniteOrNonNumber(value, exceptionState))
return true;
if (value < 0 || value > 100) {
- exceptionState.throwDOMException(IndexSizeError, ExceptionMessages::failedToSet(method, "TextTrackCue", "The value provided (" + String::number(value) + ") is not between 0 and 100."));
+ exceptionState.throwDOMException(IndexSizeError, "The value provided (" + String::number(value) + ") is not between 0 and 100.");
return true;
}
return false;
@@ -321,7 +321,7 @@ void VTTCue::setPosition(int position, ExceptionState& exceptionState)
// http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#dom-texttrackcue-position
// On setting, if the new value is negative or greater than 100, then throw an IndexSizeError exception.
// Otherwise, set the text track cue text position to the new value.
- if (isInvalidPercentage(position, "line", exceptionState))
+ if (isInvalidPercentage(position, exceptionState))
return;
// Otherwise, set the text track cue line position to the new value.
@@ -338,7 +338,7 @@ void VTTCue::setSize(int size, ExceptionState& exceptionState)
// http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#dom-texttrackcue-size
// On setting, if the new value is negative or greater than 100, then throw an IndexSizeError
// exception. Otherwise, set the text track cue size to the new value.
- if (isInvalidPercentage(size, "line", exceptionState))
+ if (isInvalidPercentage(size, exceptionState))
return;
// Otherwise, set the text track cue line position to the new value.

Powered by Google App Engine
This is Rietveld 408576698