Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: Source/core/html/track/TextTrackCue.cpp

Issue 99083002: WIP: Migrate generated bindings to new ExceptionState constructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: MessagePort. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/track/TextTrackCue.cpp
diff --git a/Source/core/html/track/TextTrackCue.cpp b/Source/core/html/track/TextTrackCue.cpp
index 45358f1e1a240c76ab4190f1ee04ff8273600415..9f8da582f63d0952583cafb03b17d882011222d4 100644
--- a/Source/core/html/track/TextTrackCue.cpp
+++ b/Source/core/html/track/TextTrackCue.cpp
@@ -51,10 +51,10 @@ TextTrackCueBox::TextTrackCueBox(Document& document)
// ----------------------------
-bool TextTrackCue::isInfiniteOrNonNumber(double value, const char* method, ExceptionState& exceptionState)
+bool TextTrackCue::isInfiniteOrNonNumber(double value, ExceptionState& exceptionState)
{
if (!std::isfinite(value)) {
- exceptionState.throwTypeError(ExceptionMessages::failedToSet(method, "TextTrackCue", ExceptionMessages::notAFiniteNumber(value)));
+ exceptionState.throwTypeError(ExceptionMessages::notAFiniteNumber(value));
return true;
}
return false;
@@ -110,7 +110,7 @@ void TextTrackCue::setId(const String& id)
void TextTrackCue::setStartTime(double value, ExceptionState& exceptionState)
{
// NaN, Infinity and -Infinity values should trigger a TypeError.
- if (isInfiniteOrNonNumber(value, "startTime", exceptionState))
+ if (isInfiniteOrNonNumber(value, exceptionState))
return;
// TODO(93143): Add spec-compliant behavior for negative time values.
@@ -125,7 +125,7 @@ void TextTrackCue::setStartTime(double value, ExceptionState& exceptionState)
void TextTrackCue::setEndTime(double value, ExceptionState& exceptionState)
{
// NaN, Infinity and -Infinity values should trigger a TypeError.
- if (isInfiniteOrNonNumber(value, "endTime", exceptionState))
+ if (isInfiniteOrNonNumber(value, exceptionState))
return;
// TODO(93143): Add spec-compliant behavior for negative time values.

Powered by Google App Engine
This is Rietveld 408576698