Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Unified Diff: courgette/disassembler_elf_32_x86.cc

Issue 990803003: Fix memory leak in DisassemblerElf32X86::ParseRel32RelocsFromSection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: courgette/disassembler_elf_32_x86.cc
diff --git a/courgette/disassembler_elf_32_x86.cc b/courgette/disassembler_elf_32_x86.cc
index d2c1c86b440a4c1f5faa7e4f93c132a7fdc5bb67..da389a42c526e91f6e03cd04b38bd78c5b4f26c2 100644
--- a/courgette/disassembler_elf_32_x86.cc
+++ b/courgette/disassembler_elf_32_x86.cc
@@ -157,6 +157,7 @@ CheckBool DisassemblerElf32X86::ParseRel32RelocsFromSection(
TypedRVAX86* rel32_rva = new TypedRVAX86(rva);
if (!rel32_rva->ComputeRelativeTarget(rel32)) {
+ delete rel32_rva;
return false;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698