Fix memory leak in DisassemblerElf32X86::ParseRel32RelocsFromSection.

courgette/disassembler_elf_32_x86.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "courgette/disassembler_elf_32_x86.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 139 matching lines @@
       if (*p == 0x0F  &&  (*(p+1) & 0xF0) == 0x80) {  // Jcc long form
         if (p[1] != 0x8A && p[1] != 0x8B)  // JPE/JPO unlikely
           rel32 = p + 2;
       }
     }
     if (rel32) {
       RVA rva = static_cast<RVA>(rel32 - adjust_pointer_to_rva);
       TypedRVAX86* rel32_rva = new TypedRVAX86(rva);
 
       if (!rel32_rva->ComputeRelativeTarget(rel32)) {
+        delete rel32_rva;
         return false;
       }
 
       RVA target_rva = rel32_rva->rva() + rel32_rva->relative_target();
       // To be valid, rel32 target must be within image, and within this
       // section.
       if (IsValidRVA(target_rva)) {
         rel32_locations_.push_back(rel32_rva);
 #if COURGETTE_HISTOGRAM_TARGETS
         ++rel32_target_rvas_[target_rva];
 #endif
         p = rel32 + 4;
         continue;
       } else {
         delete rel32_rva;
       }
     }
     p += 1;
   }
 
   return true;
 }
 
 }  // namespace courgette