Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 99073005: Merge 162590 "[REGRESSION] Button cannot be clicked with text-in..." (Closed)

Created:
7 years ago by tkent
Modified:
7 years ago
Reviewers:
seokju.kwon
CC:
blink-reviews, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, zoltan1
Visibility:
Public.

Description

Merge 162590 "[REGRESSION] Button cannot be clicked with text-in..." > [REGRESSION] Button cannot be clicked with text-indent : -99999999px after r143483. > > Merged from http://trac.webkit.org/changeset/155546. > This caused a bad repaint regression, when authors combine negative text-indent with overflow:hidden > (which is what we recommend they do): bug 121137. > Revert the change, and add a new test to make sure it doesn't regress. > > BUG=321892 > TEST= > fast/repaint/negative-text-indent-with-overflow-hidden.html > fast/events/click-with-large-negative-text-indent.html > fast/repaint/paint-caret-in-div-with-negative-indent.html > > Review URL: https://codereview.chromium.org/81833005 TBR=seokju.kwon@gmail.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163044

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-4 lines, -4 lines) Patch
A + LayoutTests/fast/events/click-with-large-negative-text-indent.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/events/click-with-large-negative-text-indent-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/repaint/negative-text-indent-with-overflow-hidden.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/repaint/negative-text-indent-with-overflow-hidden-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tkent
7 years ago (2013-12-03 01:12:59 UTC) #1
tkent
7 years ago (2013-12-03 01:13:31 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r163044.

Powered by Google App Engine
This is Rietveld 408576698