Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: Source/core/rendering/RenderBlock.cpp

Issue 99073005: Merge 162590 "[REGRESSION] Button cannot be clicked with text-in..." (Closed) Base URL: svn://svn.chromium.org/blink/branches/chromium/1700/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « LayoutTests/fast/repaint/negative-text-indent-with-overflow-hidden-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
6 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 6 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 1488 matching lines...) Expand 10 before | Expand all | Expand 10 after
1499 LayoutRect rectToApply; 1499 LayoutRect rectToApply;
1500 if (isHorizontalWritingMode()) 1500 if (isHorizontalWritingMode())
1501 rectToApply = LayoutRect(clientRect.x(), clientRect.y(), 1, max<Layo utUnit>(0, oldClientAfterEdge - clientRect.y())); 1501 rectToApply = LayoutRect(clientRect.x(), clientRect.y(), 1, max<Layo utUnit>(0, oldClientAfterEdge - clientRect.y()));
1502 else 1502 else
1503 rectToApply = LayoutRect(clientRect.x(), clientRect.y(), max<LayoutU nit>(0, oldClientAfterEdge - clientRect.x()), 1); 1503 rectToApply = LayoutRect(clientRect.x(), clientRect.y(), max<LayoutU nit>(0, oldClientAfterEdge - clientRect.x()), 1);
1504 addLayoutOverflow(rectToApply); 1504 addLayoutOverflow(rectToApply);
1505 if (hasRenderOverflow()) 1505 if (hasRenderOverflow())
1506 m_overflow->setLayoutClientAfterEdge(oldClientAfterEdge); 1506 m_overflow->setLayoutClientAfterEdge(oldClientAfterEdge);
1507 } 1507 }
1508 1508
1509 // Allow our overflow to catch cases where the caret in an empty editable el ement with negative text indent needs to get painted.
1510 LayoutUnit textIndent = textIndentOffset();
1511 if (textIndent < 0) {
1512 LayoutRect clientRect(noOverflowRect());
1513 LayoutRect rectToApply = LayoutRect(clientRect.x() + textIndent, clientR ect.y(), clientRect.width() - textIndent, clientRect.height());
1514 addContentsVisualOverflow(rectToApply);
1515 }
1516
1517 // Add visual overflow from box-shadow and border-image-outset. 1509 // Add visual overflow from box-shadow and border-image-outset.
1518 addVisualEffectOverflow(); 1510 addVisualEffectOverflow();
1519 1511
1520 // Add visual overflow from theme. 1512 // Add visual overflow from theme.
1521 addVisualOverflowFromTheme(); 1513 addVisualOverflowFromTheme();
1522 1514
1523 if (isRenderNamedFlowThread()) 1515 if (isRenderNamedFlowThread())
1524 toRenderNamedFlowThread(this)->computeOversetStateForRegions(oldClientAf terEdge); 1516 toRenderNamedFlowThread(this)->computeOversetStateForRegions(oldClientAf terEdge);
1525 } 1517 }
1526 1518
(...skipping 4325 matching lines...) Expand 10 before | Expand all | Expand 10 after
5852 void RenderBlock::showLineTreeAndMark(const InlineBox* markedBox1, const char* m arkedLabel1, const InlineBox* markedBox2, const char* markedLabel2, const Render Object* obj) const 5844 void RenderBlock::showLineTreeAndMark(const InlineBox* markedBox1, const char* m arkedLabel1, const InlineBox* markedBox2, const char* markedLabel2, const Render Object* obj) const
5853 { 5845 {
5854 showRenderObject(); 5846 showRenderObject();
5855 for (const RootInlineBox* root = firstRootBox(); root; root = root->nextRoot Box()) 5847 for (const RootInlineBox* root = firstRootBox(); root; root = root->nextRoot Box())
5856 root->showLineTreeAndMark(markedBox1, markedLabel1, markedBox2, markedLa bel2, obj, 1); 5848 root->showLineTreeAndMark(markedBox1, markedLabel1, markedBox2, markedLa bel2, obj, 1);
5857 } 5849 }
5858 5850
5859 #endif 5851 #endif
5860 5852
5861 } // namespace WebCore 5853 } // namespace WebCore
OLDNEW
« no previous file with comments | « LayoutTests/fast/repaint/negative-text-indent-with-overflow-hidden-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698