Issue 990383002: Add MediaSource.supported, annotations for supported browsers, and a minimal test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 990383002: Add MediaSource.supported, annotations for supported browsers, and a minimal test (Closed)

Created:
5 years, 9 months ago by Alan Knight

Modified:
5 years, 9 months ago

Reviewers:
terry

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Add MediaSource.supported, annotations for supported browsers, and a minimal test BUG= R=terry@google.com Committed: https://code.google.com/p/dart/source/detail?r=44472

Patch Set 1 #

Total comments: 1

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -0 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	2 chunks	+5 lines, -0 lines	0 comments	Download
A	tests/html/mediasource_test.dart	View	1 chunk	+42 lines, -0 lines	1 comment	Download
M	tools/dom/scripts/dartmetadata.py	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

terry

Minor NIT. lgtm https://codereview.chromium.org/990383002/diff/1/tests/html/mediasource_test.dart File tests/html/mediasource_test.dart (right): https://codereview.chromium.org/990383002/diff/1/tests/html/mediasource_test.dart#newcode7 tests/html/mediasource_test.dart:7: import 'dart:async'; Is this needed?

5 years, 9 months ago (2015-03-10 12:43:51 UTC) #3

Alan Knight

5 years, 9 months ago (2015-03-13 17:32:01 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 44472 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages