Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: tools/dom/scripts/dartmetadata.py

Issue 990383002: Add MediaSource.supported, annotations for supported browsers, and a minimal test (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/dom/scripts/dartmetadata.py
diff --git a/tools/dom/scripts/dartmetadata.py b/tools/dom/scripts/dartmetadata.py
index 2f1ad82925f8df88887126ff8e4acec3300e6ee9..9117f71e895d0b68bb813c13fc435eb8b50ce1e1 100644
--- a/tools/dom/scripts/dartmetadata.py
+++ b/tools/dom/scripts/dartmetadata.py
@@ -519,6 +519,13 @@ _annotations = monitored.Dict('dartmetadata._annotations', {
'MediaStreamEvent': _rtc_annotations,
'MediaStreamTrack': _rtc_annotations,
'MediaStreamTrackEvent': _rtc_annotations,
+ 'MediaSource': [
+ # TODO(alanknight): This works on Firefox 33 behind a flag and in Safari
+ # desktop, but not mobile. On theory that static false positives are worse
+ # than negatives, leave those out for now. Update once they're available.
+ "@SupportedBrowser(SupportedBrowser.CHROME)",
+ "@SupportedBrowser(SupportedBrowser.IE, '11')",
+ ],
'MutationObserver': [
"@SupportedBrowser(SupportedBrowser.CHROME)",
"@SupportedBrowser(SupportedBrowser.FIREFOX)",

Powered by Google App Engine
This is Rietveld 408576698