Fix build on solaris platforms

Fix build on solaris platforms

e8b9f2d7 introduced a different cast which broke building on Illumos.
Revert to previous behavior for V8_OS_SOLARIS only.

Found on SmartOS while building with gcc 4.9.0.

edit1: adding jochen to reviewers since he was assigned through the issue tracker and danno since he seems to do a fair amount of cross-platform work

edit2: removing BUG reference because I don't understand what LOG needs to contain (and it seems to link to chromium and not the v8 repo). Please edit commit message as appropriate.

BUG=3935
LOG=n

Committed: https://crrev.com/68d5f916d885462621d52ceafdd605ce1fd28c24
Cr-Commit-Position: refs/heads/master@{#27163}

[jbergstroem, 2015-03-09 00:56:02]

johan@bergstroem.nu changed reviewers:
+ jochen@chromium.org

[jbergstroem, 2015-03-09 01:28:16]

Build fix on solaris/illumos. Revert to previous behavior for this platform.

[jbergstroem, 2015-03-09 01:48:15]

johan@bergstroem.nu changed reviewers:
+ danno@chromium.org

[jochen (gone - plz use gerrit), 2015-03-09 16:09:11]

https://codereview.chromium.org/990063002/diff/1/src/base/platform/platform-p...
File src/base/platform/platform-posix.cc (right):

https://codereview.chromium.org/990063002/diff/1/src/base/platform/platform-p...
src/base/platform/platform-posix.cc:276: #elif V8_OS_SOLARIS
can you merge this with the previous block, i.e., V8_OS_AIX || V8_OS_SOLARIS

[jochen (gone - plz use gerrit), 2015-03-09 16:20:02]

also, please add yourself to AUTHORS for our fancy new presubmit check to work

[jbergstroem, 2015-03-09 20:34:28]

On 2015/03/09 16:09:11, jochen (traveling) wrote:
>
https://codereview.chromium.org/990063002/diff/1/src/base/platform/platform-p...
> File src/base/platform/platform-posix.cc (right):
> 
>
https://codereview.chromium.org/990063002/diff/1/src/base/platform/platform-p...
> src/base/platform/platform-posix.cc:276: #elif V8_OS_SOLARIS
> can you merge this with the previous block, i.e., V8_OS_AIX || V8_OS_SOLARIS

Unfortunately not. Hard to see (did the same mistake myself), but AIX has
`thread_self()` while the solaris equivalent is `pthread_self()`.

[jbergstroem, 2015-03-09 20:35:25]

On 2015/03/09 16:20:02, jochen (traveling) wrote:
> also, please add yourself to AUTHORS for our fancy new presubmit check to work

Absolutely. I wasn't sure if this was automated or not.

[jochen (gone - plz use gerrit), 2015-03-10 13:03:13]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2015-03-10 13:03:14]

lgtm

[commit-bot: I haz the power, 2015-03-10 13:04:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/990063002/20001

[commit-bot: I haz the power, 2015-03-10 14:16:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-10 14:16:15]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/1088)

[jbergstroem, 2015-03-10 20:57:33]

On 2015/03/10 14:16:15, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   v8_presubmit on tryserver.v8 (JOB_FAILED,
> http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/1088)

Annoying. I couldn't choose what email address to sign with from the one's I
have tied to my google account. I'll (reluctantly) update AUTHORS so we can
proceed. Sorry for the hassle.

[jochen (gone - plz use gerrit), 2015-03-11 16:01:44]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2015-03-11 16:01:44]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/990063002/#ps40001 (title:
"Use primary email in AUTHORS")

[commit-bot: I haz the power, 2015-03-11 16:02:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/990063002/40001

[commit-bot: I haz the power, 2015-03-11 16:08:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-11 16:09:00]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/1148)

[jochen (gone - plz use gerrit), 2015-03-12 15:10:47]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2015-03-12 15:11:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/990063002/40001

[commit-bot: I haz the power, 2015-03-12 15:12:42]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-12 15:12:55]

Patchset 3 (id:??) landed as
https://crrev.com/68d5f916d885462621d52ceafdd605ce1fd28c24
Cr-Commit-Position: refs/heads/master@{#27163}

[bnoordhuis, 2015-03-17 11:14:35]

Jochen, would it be possible to get this back-ported to the 4.1 and 4.2
branches?  io.js is currently floating it as a patch on top of 4.1.