Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 989913002: Move UdevDecodeString from media/midi to device/udev_linux (Closed)

Created:
5 years, 9 months ago by Adam Goode
Modified:
5 years, 9 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@seq3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move UdevDecodeString from media/midi to device/udev_linux Committed: https://crrev.com/b48f18835a8253a6ef8402e4a646fe1663726496 Cr-Commit-Position: refs/heads/master@{#319711}

Patch Set 1 #

Patch Set 2 : Use UdevDecodeString from device instead of our copy #

Patch Set 3 : Don't change BUILD.gn right now #

Patch Set 4 : Fix unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -60 lines) Patch
M device/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M device/device_tests.gyp View 1 chunk +8 lines, -0 lines 0 comments Download
M device/udev_linux/udev.h View 1 chunk +3 lines, -0 lines 0 comments Download
M device/udev_linux/udev.cc View 2 chunks +16 lines, -0 lines 0 comments Download
A device/udev_linux/udev_unittest.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M media/midi/midi_manager_alsa.h View 1 chunk +1 line, -5 lines 0 comments Download
M media/midi/midi_manager_alsa.cc View 1 6 chunks +12 lines, -40 lines 0 comments Download
M media/midi/midi_manager_alsa_unittest.cc View 1 2 3 3 chunks +17 lines, -15 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Adam Goode
5 years, 9 months ago (2015-03-08 19:59:31 UTC) #2
Takashi Toyoshima
lgtm from media/midi side, but don't you update components/storage_monitor/udev_util_linux.cc to use it or ping relevant ...
5 years, 9 months ago (2015-03-09 06:50:39 UTC) #3
Adam Goode
On 2015/03/09 06:50:39, Takashi Toyoshima (chromium) wrote: > lgtm from media/midi side, but don't you ...
5 years, 9 months ago (2015-03-09 11:56:48 UTC) #4
Ken Rockot(use gerrit already)
lgtm
5 years, 9 months ago (2015-03-09 16:19:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989913002/60001
5 years, 9 months ago (2015-03-09 19:17:44 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-09 19:34:38 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 19:35:35 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b48f18835a8253a6ef8402e4a646fe1663726496
Cr-Commit-Position: refs/heads/master@{#319711}

Powered by Google App Engine
This is Rietveld 408576698