Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Unified Diff: media/midi/midi_manager_alsa.h

Issue 989913002: Move UdevDecodeString from media/midi to device/udev_linux (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@seq3
Patch Set: Fix unit tests Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/udev_linux/udev_unittest.cc ('k') | media/midi/midi_manager_alsa.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/midi/midi_manager_alsa.h
diff --git a/media/midi/midi_manager_alsa.h b/media/midi/midi_manager_alsa.h
index d06ff760c0483cf0bd4b6e075ed346cd5deba350..86eb18decd49f8e3398b3b49e238a24b1acef9c7 100644
--- a/media/midi/midi_manager_alsa.h
+++ b/media/midi/midi_manager_alsa.h
@@ -57,16 +57,12 @@ class MEDIA_EXPORT MidiManagerAlsa : public MidiManager {
// Extracts the manufacturer using heuristics and a variety of sources.
static std::string ExtractManufacturerString(
- const std::string& udev_id_vendor_enc,
+ const std::string& udev_id_vendor,
const std::string& udev_id_vendor_id,
const std::string& udev_id_vendor_from_database,
const std::string& alsa_name,
const std::string& alsa_longname);
- // TODO(agoode): Move this into a common place. Maybe device/udev_linux?
- // Decodes just \xXX in strings.
- static std::string UnescapeUdev(const std::string& s);
-
std::string alsa_name_;
std::string manufacturer_;
std::string alsa_driver_;
« no previous file with comments | « device/udev_linux/udev_unittest.cc ('k') | media/midi/midi_manager_alsa.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698