Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 989783002: [Android] Default allow infobars to hide on scroll. (Closed)

Created:
5 years, 9 months ago by Ted C
Modified:
5 years, 9 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Default allow infobars to hide on scroll. Accidentally disabled in: https://codereview.chromium.org/968453002 BUG=452614 Committed: https://crrev.com/1508b8b51d59daece5b784b352ad457264c06cc4 Cr-Commit-Position: refs/heads/master@{#319640}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (12 generated)
Ted C
PTAL :-)
5 years, 9 months ago (2015-03-07 01:28:29 UTC) #2
gone
lgtm Er, whoops. Good catch.
5 years, 9 months ago (2015-03-07 02:32:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989783002/1
5 years, 9 months ago (2015-03-07 02:33:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_rel_ng on ...
5 years, 9 months ago (2015-03-07 04:34:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989783002/1
5 years, 9 months ago (2015-03-07 04:47:47 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_rel_ng on ...
5 years, 9 months ago (2015-03-07 06:48:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989783002/1
5 years, 9 months ago (2015-03-07 16:09:43 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_rel_ng on ...
5 years, 9 months ago (2015-03-07 18:10:11 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989783002/1
5 years, 9 months ago (2015-03-09 00:12:18 UTC) #17
commit-bot: I haz the power
Failed to apply the patch.
5 years, 9 months ago (2015-03-09 00:35:52 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989783002/20001
5 years, 9 months ago (2015-03-09 15:21:04 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-09 15:53:30 UTC) #24
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 15:53:56 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1508b8b51d59daece5b784b352ad457264c06cc4
Cr-Commit-Position: refs/heads/master@{#319640}

Powered by Google App Engine
This is Rietveld 408576698