Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 968453002: Stop infobar autohiding when Touch Exploration enabled (Closed)

Created:
5 years, 9 months ago by gone
Modified:
5 years, 9 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop infobar autohiding when Touch Exploration enabled Adds a way to stop InfoBars and SwipableOverlayViews from auto-hiding. BUG=452614 Committed: https://crrev.com/d4cb99134181800a2add6bb5cdc369c8b9c8324a Cr-Commit-Position: refs/heads/master@{#318542}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/banners/SwipableOverlayView.java View 1 4 chunks +17 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java View 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
gone
5 years, 9 months ago (2015-02-27 22:06:11 UTC) #2
Ted C
lgtm https://codereview.chromium.org/968453002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/banners/SwipableOverlayView.java File chrome/android/java/src/org/chromium/chrome/browser/banners/SwipableOverlayView.java (right): https://codereview.chromium.org/968453002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/banners/SwipableOverlayView.java#newcode253 chrome/android/java/src/org/chromium/chrome/browser/banners/SwipableOverlayView.java:253: ObjectAnimator.ofFloat(this, "alpha", 0.f, 1.f).setDuration(REATTACH_FADE_IN_MS) FWIW, you could replace ...
5 years, 9 months ago (2015-02-27 22:39:35 UTC) #3
gone
Switched over.
5 years, 9 months ago (2015-02-27 22:43:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/968453002/20001
5 years, 9 months ago (2015-02-27 22:45:21 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-02-27 23:33:53 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-02-27 23:34:37 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d4cb99134181800a2add6bb5cdc369c8b9c8324a
Cr-Commit-Position: refs/heads/master@{#318542}

Powered by Google App Engine
This is Rietveld 408576698