Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 989733003: util/mac: Provide wrappers for <launch.h> functions deprecated in 10.10 (Closed)

Created:
5 years, 9 months ago by Mark Mentovai
Modified:
5 years, 9 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

util/mac: Provide wrappers for <launch.h> functions deprecated in 10.10. The 10.10 SDK deprecates <launch.h>, but this file is still useful and is used by util/mac/launchd.* and util/mac/service_management.*. Wrap the <launch.h> functions in versions that ignore the deprecation warnings. BUG=crashpad:10 R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/bc401f6aac22c3fce8f9553ecfb231251cc55dbf

Patch Set 1 #

Patch Set 2 : DEPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -91 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M util/mac/launchd.h View 1 chunk +108 lines, -0 lines 0 comments Download
M util/mac/launchd.mm View 8 chunks +9 lines, -10 lines 0 comments Download
M util/mac/launchd_test.mm View 8 chunks +52 lines, -55 lines 0 comments Download
M util/mac/service_management.cc View 4 chunks +22 lines, -25 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
This needs a DEPS roll with https://codereview.chromium.org/981803004, which will be included once that lands.
5 years, 9 months ago (2015-03-06 23:36:57 UTC) #2
Robert Sesek
Sigh, LGTM. Set BUG= please.
5 years, 9 months ago (2015-03-07 01:24:55 UTC) #3
Mark Mentovai
5 years, 9 months ago (2015-03-07 03:27:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
bc401f6aac22c3fce8f9553ecfb231251cc55dbf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698