Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 981803004: 10.10 compatibility for base::mac::ScopedLaunchData (Closed)

Created:
5 years, 9 months ago by Mark Mentovai
Modified:
5 years, 9 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/mini_chromium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

10.10 compatibility for base::mac::ScopedLaunchData. The 10.10 SDK deprecates <launch.h>, but this file is still useful and ScopedLaunchData uses launch_data_free(). Ignore the deprecation warning for this call. BUG=crashpad:11 R=rsesek@chromium.org Committed: https://chromium.googlesource.com/chromium/mini_chromium/+/e7847b381703096126b37539c62a0718671d6100

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M base/mac/scoped_launch_data.h View 2 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
5 years, 9 months ago (2015-03-06 23:37:01 UTC) #2
Robert Sesek
Set the BUG= please. LGTM
5 years, 9 months ago (2015-03-07 01:20:30 UTC) #3
Mark Mentovai
5 years, 9 months ago (2015-03-07 03:24:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e7847b381703096126b37539c62a0718671d6100 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698