Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 989683004: Remove software paint FrameSubscriber from tab capture. (Closed)

Created:
5 years, 9 months ago by miu
Modified:
5 years, 9 months ago
Reviewers:
hubbe
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove software paint FrameSubscriber from tab capture. All tab capture platforms have supported capture via event-driven compositor updates for quite a while now. The "notification of backing store change" code path never triggers, except in certain edge cases where extra frame captures will be started. The extra frame captures are bad for the user experience, since the extra frames reduce video playback smoothness. The extra frame captures were also throwing-off the "out-of-order frame delivery" logic, causing wanted frames to be dropped. BUG=464475 Committed: https://crrev.com/365c4b25fb7cfcebf166ca7b24d11561731f5b80 Cr-Commit-Position: refs/heads/master@{#319549}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -76 lines) Patch
M content/browser/media/capture/content_video_capture_device_core.cc View 2 chunks +1 line, -4 lines 0 comments Download
M content/browser/media/capture/video_capture_oracle.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/media/capture/video_capture_oracle.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/media/capture/web_contents_video_capture_device.cc View 8 chunks +6 lines, -70 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
miu
hubbe: PTAL.
5 years, 9 months ago (2015-03-06 23:13:27 UTC) #2
hubbe
lgtm
5 years, 9 months ago (2015-03-06 23:39:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989683004/1
5 years, 9 months ago (2015-03-07 00:19:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_rel_ng on ...
5 years, 9 months ago (2015-03-07 01:13:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989683004/1
5 years, 9 months ago (2015-03-07 01:53:01 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-07 03:14:52 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-07 03:15:50 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/365c4b25fb7cfcebf166ca7b24d11561731f5b80
Cr-Commit-Position: refs/heads/master@{#319549}

Powered by Google App Engine
This is Rietveld 408576698