Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1470)

Unified Diff: content/browser/media/capture/content_video_capture_device_core.cc

Issue 989683004: Remove software paint FrameSubscriber from tab capture. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/media/capture/video_capture_oracle.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/media/capture/content_video_capture_device_core.cc
diff --git a/content/browser/media/capture/content_video_capture_device_core.cc b/content/browser/media/capture/content_video_capture_device_core.cc
index c43c623db08a204d7371f16eae45b88bedab01d0..4a85a77566c15ff28b9cb0a8b473b061503a2575 100644
--- a/content/browser/media/capture/content_video_capture_device_core.cc
+++ b/content/browser/media/capture/content_video_capture_device_core.cc
@@ -83,9 +83,6 @@ bool ThreadSafeCaptureOracle::ObserveEventAndDecideCapture(
client_->ReserveOutputBuffer(video_frame_format, coded_size);
const bool should_capture =
oracle_.ObserveEventAndDecideCapture(event, damage_rect, event_time);
- const bool content_is_dirty =
- (event == VideoCaptureOracle::kCompositorUpdate ||
- event == VideoCaptureOracle::kSoftwarePaint);
const char* event_name =
(event == VideoCaptureOracle::kTimerPoll ? "poll" :
(event == VideoCaptureOracle::kCompositorUpdate ? "gpu" :
@@ -100,7 +97,7 @@ bool ThreadSafeCaptureOracle::ObserveEventAndDecideCapture(
event_name);
return false;
} else if (!should_capture && output_buffer.get()) {
- if (content_is_dirty) {
+ if (event == VideoCaptureOracle::kCompositorUpdate) {
// This is a normal and acceptable way to drop a frame. We've hit our
// capture rate limit: for example, the content is animating at 60fps but
// we're capturing at 30fps.
« no previous file with comments | « no previous file | content/browser/media/capture/video_capture_oracle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698