components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h - Issue 989663002: HistoricNetworkStatsInfoToValue should use statistics prefs values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h

Issue 989663002: HistoricNetworkStatsInfoToValue should use statistics prefs values (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/webui/net_internals/bandwidth_view.js ('K') | « chrome/test/data/webui/net_internals/bandwidth_view.js ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc » ('j') | components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h

index 186a092e35c4c7c1efa0b62a5fc2c4ffea4b9483..0d7b1b23c2aae097652551af9c2c88b886f1b581 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h

@@ -74,12 +74,6 @@ class DataReductionProxyNetworkDelegate : public net::LayeredNetworkDelegate {

BooleanPrefMember* data_reduction_proxy_enabled,

DataReductionProxyUsageStats* usage_stats);

- // Creates a |Value| summary of the persistent state of the network session.

- // The caller is responsible for deleting the returned value.

- // Must be called on the UI thread.

- static base::Value* HistoricNetworkStatsInfoToValue(

- PrefService* profile_prefs);

// Creates a |Value| summary of the state of the network session. The caller

// is responsible for deleting the returned value.

base::Value* SessionNetworkStatsInfoToValue() const;