components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.h - Issue 989663002: HistoricNetworkStatsInfoToValue should use statistics prefs values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.h

Issue 989663002: HistoricNetworkStatsInfoToValue should use statistics prefs values (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/webui/net_internals/bandwidth_view.js ('K') | « components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.cc » ('j') | components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.h

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.h

index 3aea4f40646b4cfc2109e28b3b56b63651563c72..70d5798eedac1182a4016e9d986934f74999edd2 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.h

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.h

@@ -13,6 +13,7 @@

#include "base/memory/weak_ptr.h"

#include "base/threading/thread_checker.h"

#include "base/time/time.h"

+#include "base/values.h"

#include "components/data_reduction_proxy/core/common/data_reduction_proxy_pref_names.h"

class PrefChangeRegistrar;

@@ -64,6 +65,11 @@ public:

// |DataReductionProxyListPrefMap| to |pref_service|.

void WritePrefs();

+ // Creates a |Value| summary of the persistent state of the network session.

+ // The caller is responsible for deleting the returned value.

+ // Must be called on the UI thread.

+ base::Value* HistoricNetworkStatsInfoToValue();

bengr 2015/03/09 16:19:46 Can base::Value be forward declared instead?

megjablon 2015/03/09 20:15:40 Done.

base::WeakPtr<DataReductionProxyStatisticsPrefs> GetWeakPtr();

private: