PRESUBMIT.py - Issue 989533002: PRESUBMIT.py, more helpful and stable error message for #include check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 989533002: PRESUBMIT.py, more helpful and stable error message for #include check. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index a57a2c01b4401b1bacb8dad25121ac874ed74bf1..f931353e3b74ec5aecd287a287a7a2333129c5d5 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -62,9 +62,9 @@ _TEST_ONLY_WARNING = (

_INCLUDE_ORDER_WARNING = (

- 'Your #include order seems to be broken. Send mail to\n'

- 'marja@chromium.org if this is not the case.')

+ 'Your #include order seems to be broken. Remember to use the right '

+ 'collation (LC_COLLATE=C) and check http://google-styleguide.googlecode.com'

jochen (gone - plz use gerrit) 2015/03/06 17:11:04 can we have an https URL plz?

marja 2015/03/09 09:32:34 Done.

+ '/svn/trunk/cppguide.html#Names_and_Order_of_Includes')

_BANNED_OBJC_FUNCTIONS = (

(

« no previous file with comments | « no previous file | no next file » | no next file with comments »