Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 989523005: Avoid duplicates in SPDY's write blocked list. (Closed)

Created:
5 years, 9 months ago by Bence
Modified:
5 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid duplicates in SPDY's write blocked list. Add a map from stream ID to priority to track which stream IDs are already in the write blocked list. And git cl format. This CL lands server change 86595615 by birenroy. BUG= Committed: https://crrev.com/e4c688d207dba469310fcbbb64e281cd85f7cc5e Cr-Commit-Position: refs/heads/master@{#319743}

Patch Set 1 #

Patch Set 2 : Use hash_map. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -62 lines) Patch
M net/quic/quic_session.cc View 1 chunk +1 line, -0 lines 1 comment Download
M net/quic/quic_write_blocked_list.h View 2 chunks +3 lines, -2 lines 0 comments Download
M net/quic/quic_write_blocked_list.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M net/quic/quic_write_blocked_list_test.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M net/spdy/write_blocked_list.h View 1 5 chunks +53 lines, -1 line 0 comments Download
M net/spdy/write_blocked_list_test.cc View 3 chunks +91 lines, -51 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Bence
Ryan, PTAL. This change uses |unordered_map|, which is a C++11 library feature, and thus not ...
5 years, 9 months ago (2015-03-08 17:33:36 UTC) #2
Ryan Hamilton
std::unordered_map has O(1) access time. I think hash_map would be a better choice. What do ...
5 years, 9 months ago (2015-03-09 03:22:25 UTC) #3
Bence
Ryan, PTAL.
5 years, 9 months ago (2015-03-09 14:59:18 UTC) #4
Ryan Hamilton
lgtm
5 years, 9 months ago (2015-03-09 17:45:37 UTC) #5
Ryan Hamilton
https://codereview.chromium.org/989523005/diff/20001/net/quic/quic_session.cc File net/quic/quic_session.cc (right): https://codereview.chromium.org/989523005/diff/20001/net/quic/quic_session.cc#newcode105 net/quic/quic_session.cc:105: write_blocked_streams_(true), Should this be true or false? seems like ...
5 years, 9 months ago (2015-03-09 17:46:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989523005/20001
5 years, 9 months ago (2015-03-09 19:29:47 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-09 22:10:07 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 22:10:57 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e4c688d207dba469310fcbbb64e281cd85f7cc5e
Cr-Commit-Position: refs/heads/master@{#319743}

Powered by Google App Engine
This is Rietveld 408576698