net/quic/quic_write_blocked_list.h - Issue 989523005: Avoid duplicates in SPDY's write blocked list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_write_blocked_list.h

Issue 989523005: Avoid duplicates in SPDY's write blocked list. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use hash_map. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/quic_write_blocked_list.h

diff --git a/net/quic/quic_write_blocked_list.h b/net/quic/quic_write_blocked_list.h

index 6727fb4e826e2fae1d5653a153ab3cbcacd1347b..cb6a89a3ce3ce3b791ba9bf83053939960b4615e 100644

--- a/net/quic/quic_write_blocked_list.h

+++ b/net/quic/quic_write_blocked_list.h

@@ -24,7 +24,7 @@ class NET_EXPORT_PRIVATE QuicWriteBlockedList {

static const QuicPriority kHighestPriority;

static const QuicPriority kLowestPriority;

- QuicWriteBlockedList();

+ explicit QuicWriteBlockedList(bool avoid_duplicate_streams);

~QuicWriteBlockedList();

bool HasWriteBlockedDataStreams() const {

@@ -80,7 +80,8 @@ class NET_EXPORT_PRIVATE QuicWriteBlockedList {

return;

}

- if (blocked_streams_.find(stream_id) != blocked_streams_.end()) {

+ if (!base_write_blocked_list_.avoids_inserting_duplicates() &&

+ blocked_streams_.find(stream_id) != blocked_streams_.end()) {

DVLOG(1) << "Stream " << stream_id << " already in write blocked list.";

return;

}