Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 989343002: Revert of base: Fix/add header #ifndef guards. (Closed)

Created:
5 years, 9 months ago by Bence
Modified:
5 years, 9 months ago
Reviewers:
danakj, Nico
CC:
chromium-reviews, extensions-reviews_chromium.org, Dai Mikurube (NOT FULLTIME), wfh+watch_chromium.org, gavinp+memory_chromium.org, sadrul, grt+watch_chromium.org, tfarina, tracing+reviews_chromium.org, chromium-apps-reviews_chromium.org, chirantan+watch_chromium.org, erikwright+watch_chromium.org, jshin+watch_chromium.org, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of base: Fix/add header #ifndef guards. (patchset #2 id:20001 of https://codereview.chromium.org/985003004/) Reason for revert: This seems to be causing tree closing compile failure https://build.chromium.org/p/chromium/builders/Android/builds/36135/steps/compile/logs/stdio. Original issue's description: > base: Fix/add header #ifndef guards. > > Header guards should be defined based on the path and file name of the > header file. Some headers have it wrong, some are missing the guards, > and some just have the matching comment wrong. > > R=Nico > BUG=464816 > > Committed: https://crrev.com/301b392761fd8f66f3a701ab1dd011c6e7a55e19 > Cr-Commit-Position: refs/heads/master@{#319722} TBR=thakis@chromium.org,danakj@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=464816 Committed: https://crrev.com/2220bd6553b4aae764ed66b24f5aa6e398c70b68 Cr-Commit-Position: refs/heads/master@{#319728}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -125 lines) Patch
M base/allocator/allocator_extension.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/allocator/allocator_extension_thunks.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/android/important_file_writer_android.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/android/java_handler_thread.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/android/jni_generator/golden_sample_for_tests_jni.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/android/jni_generator/sample_for_tests.h View 2 chunks +0 lines, -5 lines 0 comments Download
M base/android/library_loader/library_load_from_apk_status_codes.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/android/library_loader/library_loader_hooks.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/android/trace_event_binding.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/build_time.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/callback_forward.h View 1 chunk +1 line, -1 line 0 comments Download
M base/debug/debugger.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/debug/profiler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/deferred_sequenced_task_runner.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/event_types.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/i18n/string_compare.h View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/timezone.h View 1 chunk +1 line, -1 line 0 comments Download
M base/mac/cocoa_protocols.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/mac/libdispatch_task_runner.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/memory/memory_pressure_listener.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/message_loop/message_pump_default.h View 1 chunk +1 line, -1 line 0 comments Download
M base/message_loop/message_pump_dispatcher.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/numerics/safe_conversions.h View 2 chunks +4 lines, -3 lines 0 comments Download
M base/numerics/safe_conversions_impl.h View 2 chunks +4 lines, -3 lines 0 comments Download
M base/numerics/safe_math.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/numerics/safe_math_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/pending_task.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/process/internal_linux.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/process/process.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/scoped_native_library.h View 1 chunk +1 line, -1 line 0 comments Download
M base/sequenced_task_runner.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/test/null_task_runner.h View 2 chunks +0 lines, -5 lines 0 comments Download
M base/test/sequenced_task_runner_test_template.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/test/sequenced_worker_pool_owner.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/test/simple_test_clock.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/test/simple_test_tick_clock.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/test/task_runner_test_template.h View 1 chunk +1 line, -1 line 0 comments Download
M base/test/test_reg_util_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/time/clock.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/time/default_clock.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/time/default_tick_clock.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/time/tick_clock.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/timer/mock_timer.h View 1 chunk +1 line, -1 line 0 comments Download
M base/trace_event/trace_event.h View 1 chunk +1 line, -1 line 0 comments Download
M base/trace_event/trace_event_synthetic_delay.h View 1 chunk +1 line, -1 line 0 comments Download
M base/win/object_watcher.h View 1 chunk +1 line, -1 line 0 comments Download
M base/win/scoped_bstr.h View 1 chunk +1 line, -1 line 0 comments Download
M base/win/scoped_handle.h View 1 chunk +1 line, -1 line 0 comments Download
M base/win/startup_information.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Bence
Created Revert of base: Fix/add header #ifndef guards.
5 years, 9 months ago (2015-03-09 20:44:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989343002/1
5 years, 9 months ago (2015-03-09 20:44:20 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 20:47:52 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 20:49:54 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2220bd6553b4aae764ed66b24f5aa6e398c70b68
Cr-Commit-Position: refs/heads/master@{#319728}

Powered by Google App Engine
This is Rietveld 408576698