Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 989273003: Converted FullCode to have its own list of known intrinsics. (Closed)

Created:
5 years, 9 months ago by Sven Panne
Modified:
5 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Converted FullCode to have its own list of known intrinsics. Combined the various lists, the only slightly ugly thing is now the distinction between intrinsics returning pairs and the rest, but that's no big deal. BUG=v8:3947 LOG=n Committed: https://crrev.com/611eb2589449fe0d2f3f22559e32ec293983c657 Cr-Commit-Position: refs/heads/master@{#27135}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed comment. Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -213 lines) Patch
M src/arm/full-codegen-arm.cc View 3 chunks +22 lines, -16 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 3 chunks +22 lines, -16 lines 0 comments Download
M src/full-codegen.h View 2 chunks +46 lines, -15 lines 0 comments Download
M src/full-codegen.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 3 chunks +24 lines, -20 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 3 chunks +22 lines, -16 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 3 chunks +21 lines, -16 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 3 chunks +22 lines, -16 lines 0 comments Download
M src/runtime/runtime.h View 1 6 chunks +16 lines, -24 lines 0 comments Download
M src/runtime/runtime.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/serialize.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 2 chunks +21 lines, -15 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 3 chunks +23 lines, -20 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Sven Panne
5 years, 9 months ago (2015-03-11 12:37:31 UTC) #2
Michael Starzinger
LGTM. https://codereview.chromium.org/989273003/diff/1/src/runtime/runtime.h File src/runtime/runtime.h (right): https://codereview.chromium.org/989273003/diff/1/src/runtime/runtime.h#newcode638 src/runtime/runtime.h:638: // as runtime functions. The come in 2 ...
5 years, 9 months ago (2015-03-11 12:57:33 UTC) #3
Sven Panne
https://codereview.chromium.org/989273003/diff/1/src/runtime/runtime.h File src/runtime/runtime.h (right): https://codereview.chromium.org/989273003/diff/1/src/runtime/runtime.h#newcode638 src/runtime/runtime.h:638: // as runtime functions. The come in 2 flavors, ...
5 years, 9 months ago (2015-03-11 13:40:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989273003/20001
5 years, 9 months ago (2015-03-11 13:41:00 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-11 14:03:26 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 14:03:39 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/611eb2589449fe0d2f3f22559e32ec293983c657
Cr-Commit-Position: refs/heads/master@{#27135}

Powered by Google App Engine
This is Rietveld 408576698