Converted FullCode to have its own list of known intrinsics.

src/runtime/runtime.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_RUNTIME_RUNTIME_H_
 #define V8_RUNTIME_RUNTIME_H_
 
 #include "src/allocation.h"
 #include "src/objects.h"
 #include "src/zone.h"
 
 namespace v8 {
 namespace internal {
 
 // The interface to C++ runtime functions.
 
 // ----------------------------------------------------------------------------
-// RUNTIME_FUNCTION_LIST_ALWAYS defines runtime calls available in both
-// release and debug mode.
-// This macro should only be used by the macro RUNTIME_FUNCTION_LIST.
-
 // WARNING: RUNTIME_FUNCTION_LIST_ALWAYS_* is a very large macro that caused
 // MSVC Intellisense to crash.  It was broken into two macros to work around
 // this problem. Please avoid large recursive macros whenever possible.
 #define RUNTIME_FUNCTION_LIST_ALWAYS_1(F)      \
   /* Property access */                        \
   F(GetProperty, 2, 1)                         \
   F(KeyedGetProperty, 2, 1)                    \
   F(DeleteProperty, 3, 1)                      \
   F(HasOwnProperty, 2, 1)                      \
   F(HasProperty, 2, 1)                         \
@@ skipping 591 matching lines @@
   F(BreakIteratorFirst, 1, 1)                 \
   F(BreakIteratorNext, 1, 1)                  \
   F(BreakIteratorCurrent, 1, 1)               \
   F(BreakIteratorBreakType, 1, 1)
 
 #else
 #define RUNTIME_FUNCTION_LIST_I18N_SUPPORT(F)
 #endif
 
 
-// ----------------------------------------------------------------------------
-// RUNTIME_FUNCTION_LIST defines all runtime functions accessed
-// either directly by id (via the code generator), or indirectly
-// via a native call by name (from within JS code).
-// Entries have the form F(name, number of arguments, number of return values).
-
 #define RUNTIME_FUNCTION_LIST_RETURN_OBJECT(F) \
   RUNTIME_FUNCTION_LIST_ALWAYS_1(F)            \
   RUNTIME_FUNCTION_LIST_ALWAYS_2(F)            \
   RUNTIME_FUNCTION_LIST_ALWAYS_3(F)            \
   RUNTIME_FUNCTION_LIST_DEBUGGER(F)            \
   RUNTIME_FUNCTION_LIST_I18N_SUPPORT(F)
 
 
+// RUNTIME_FUNCTION_LIST_ defines the intrinsics typically implemented only
+// as runtime functions. The come in 2 flavors, either returning an object or

[Michael Starzinger, 2015/03/11 12:57:33]

nit: s/The/These/ in the comment.

[Sven Panne, 2015/03/11 13:40:34]

Done.

+// returning a pair.
+// Entries have the form F(name, number of arguments, number of return values).
 #define RUNTIME_FUNCTION_LIST(F)         \
   RUNTIME_FUNCTION_LIST_RETURN_OBJECT(F) \
   RUNTIME_FUNCTION_LIST_RETURN_PAIR(F)
 
+
 // ----------------------------------------------------------------------------
-// INLINE_FUNCTION_LIST defines all inlined functions accessed
-// with a native call of the form %_name from within JS code.
+// INLINE_FUNCTION_LIST defines the intrinsics typically handled specially by
+// the various compilers.
 // Entries have the form F(name, number of arguments, number of return values).
 #define INLINE_FUNCTION_LIST(F)                             \
   F(IsSmi, 1, 1)                                            \
   F(IsNonNegativeSmi, 1, 1)                                 \
   F(IsArray, 1, 1)                                          \
   F(IsRegExp, 1, 1)                                         \
   F(IsJSProxy, 1, 1)                                        \
   F(IsConstructCall, 0, 1)                                  \
   F(CallFunction, -1 /* receiver + n args + function */, 1) \
   F(DefaultConstructorCallSuper, 0, 1)                      \
@@ skipping 26 matching lines @@
   F(SubString, 3, 1)                                        \
   F(StringCompare, 2, 1)                                    \
   F(RegExpExec, 4, 1)                                       \
   F(RegExpConstructResult, 3, 1)                            \
   F(GetFromCache, 2, 1)                                     \
   F(NumberToString, 1, 1)                                   \
   F(DebugIsActive, 0, 1)
 
 
 // ----------------------------------------------------------------------------
-// INLINE_OPTIMIZED_FUNCTION_LIST defines all inlined functions accessed
-// with a native call of the form %_name from within JS code that also have
-// a corresponding runtime function, that is called from non-optimized code.
-// For the benefit of (fuzz) tests, the runtime version can also be called
-// directly as %name (i.e. without the leading underscore).
+// INLINE_OPTIMIZED_FUNCTION_LIST defines the intrinsics typically handled
+// specially by Crankshaft.
 // Entries have the form F(name, number of arguments, number of return values).
 #define INLINE_OPTIMIZED_FUNCTION_LIST(F) \
   /* Typed Arrays */                      \
   F(TypedArrayInitialize, 5, 1)           \
   F(DataViewInitialize, 4, 1)             \
   F(MaxSmi, 0, 1)                         \
   F(TypedArrayMaxSizeInHeap, 0, 1)        \
   F(ArrayBufferViewGetByteLength, 1, 1)   \
   F(ArrayBufferViewGetByteOffset, 1, 1)   \
   F(TypedArrayGetLength, 1, 1)            \
@@ skipping 18 matching lines @@
   F(SetClear, 1, 1)                       \
   F(SetDelete, 2, 1)                      \
   F(SetGetSize, 1, 1)                     \
   F(SetHas, 2, 1)                         \
   F(SetInitialize, 1, 1)                  \
   /* Arrays */                            \
   F(HasFastPackedElements, 1, 1)          \
   F(GetPrototype, 1, 1)
 
 
+#define FOR_EACH_INTRINSIC(F) \
+  RUNTIME_FUNCTION_LIST(F)    \
+  INLINE_FUNCTION_LIST(F)     \
+  INLINE_OPTIMIZED_FUNCTION_LIST(F)
+
 //---------------------------------------------------------------------------
 // Runtime provides access to all C++ runtime functions.
 
 class RuntimeState {
  public:
   unibrow::Mapping<unibrow::ToUppercase, 128>* to_upper_mapping() {
     return &to_upper_mapping_;
   }
   unibrow::Mapping<unibrow::ToLowercase, 128>* to_lower_mapping() {
     return &to_lower_mapping_;
@@ skipping 12 matching lines @@
 
 
 class JavaScriptFrameIterator;  // Forward declaration.
 
 
 class Runtime : public AllStatic {
  public:
   enum FunctionId {
 #define F(name, nargs, ressize) k##name,
 #define I(name, nargs, ressize) kInline##name,
-    RUNTIME_FUNCTION_LIST(F) INLINE_FUNCTION_LIST(F)
-        INLINE_OPTIMIZED_FUNCTION_LIST(F) RUNTIME_FUNCTION_LIST(I)
-            INLINE_FUNCTION_LIST(I) INLINE_OPTIMIZED_FUNCTION_LIST(I)
+    FOR_EACH_INTRINSIC(F) FOR_EACH_INTRINSIC(I)
 #undef I
 #undef F
-                kNumFunctions,
-    // TODO(svenpanne) The values below are cruel hacks, remove them!
-    kFirstInlineFunction = kInlineIsSmi,
-    kLastInlineFunction = kInlineDebugIsActive
+        kNumFunctions,
   };
 
   enum IntrinsicType { RUNTIME, INLINE };
 
   // Intrinsic function descriptor.
   struct Function {
     FunctionId function_id;
     IntrinsicType intrinsic_type;
     // The JS name of the function.
     const char* name;
@@ skipping 110 matching lines @@
 
 class DeclareGlobalsEvalFlag : public BitField<bool, 0, 1> {};
 class DeclareGlobalsNativeFlag : public BitField<bool, 1, 1> {};
 STATIC_ASSERT(LANGUAGE_END == 3);
 class DeclareGlobalsLanguageMode : public BitField<LanguageMode, 2, 2> {};
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_RUNTIME_RUNTIME_H_