Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 989253003: Revert of Output closure-compiled JavaScript files (Closed)

Created:
5 years, 9 months ago by Marc Treib
Modified:
5 years, 9 months ago
Reviewers:
Theresa, Dan Beam
CC:
chromium-reviews, vitalyp+closure_chromium.org, noyau+watch_chromium.org, arv+watch_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Output closure-compiled JavaScript files (patchset #10 id:180001 of https://codereview.chromium.org/958383003/) Reason for revert: Likely broke the build, e.g. http://build.chromium.org/p/chromium/buildstatus?builder=Linux&number=59264 http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%20Builder&number=18925 http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Builder%20%28dbg%29%2832%29&number=34383 Original issue's description: > Output closure-compiled JavaScript files > > If generate_output is set, chcker.py adds compiler flags to actually > output the compiled JS. It will also output a source map if the build > is Debug. > > BUG=393874 > > Committed: https://crrev.com/b7f849b027b42917a032dca4f2467db357fa26a4 > Cr-Commit-Position: refs/heads/master@{#319637} TBR=dbeam@chromium.org,twellington@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=393874 Committed: https://crrev.com/30fc31d16b0d87a21ef7f66f4bd676245180a719 Cr-Commit-Position: refs/heads/master@{#319639}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -21 lines) Patch
M third_party/closure_compiler/checker.py View 7 chunks +11 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Marc Treib
Created Revert of Output closure-compiled JavaScript files
5 years, 9 months ago (2015-03-09 15:50:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989253003/1
5 years, 9 months ago (2015-03-09 15:50:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 15:51:37 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 15:52:02 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/30fc31d16b0d87a21ef7f66f4bd676245180a719
Cr-Commit-Position: refs/heads/master@{#319639}

Powered by Google App Engine
This is Rietveld 408576698