Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 989213003: Roll PDFium to 1e580a10fad09833552deb797128e00c50d74bce (Closed)

Created:
5 years, 9 months ago by Tom Sepez
Modified:
5 years, 9 months ago
Reviewers:
Lei Zhang, brettw, dgrogan
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll PDFium to 1e580a10fad09833552deb797128e00c50d74bce This brings in: 1e580a1 Fix multiply defined macro in zlib.h on linux_chromium_clobber_rel_ng builder. 0700106 Make conversions for CPDF_Link explicit. 8842c62 Fix the pdfium component build. 5a370d7 Make conversion between CPDF_Dest and its object explicit. 7348fae Add gmock to .gitignore 624b6c1 Make conversion between CPDF_Action and its dictionary explicit. 61c25ee Merge to Master: Fix a compiling error in fxjs_v8.h e1671bd Kill off JS_ErrorString type. b720d0a Return error information from pdfium to JS. 944ccad Do hit tests against Annots in reverse order. 5b47dbf Remove unused IDS_ constants from pdfium. 3d25502 Pull in gmock for standalone pdfium builds. ec61a85 Upgrade openjpeg to revision 2997. 42a8ada Implement a delegate for EmbedderTests. 57e4c86 Kill off unused IFXJS interface methods. 4351ac2 Fix compilation error on Windows. f9cfdda Add small flate decode unit test. e796478 Kill multi-byte comments in fxet_list.h 23f9288 Convert pdfium expected test results to PNG format. 0fd53cf Fix GN build after PNG support backport ef1e85c Backport PNG output format to origin/master branch. BUG=445408, 457493, PDFIUM:123 Committed: https://crrev.com/608e59f9ceecd5b60ae5e50c4f0da4bc6a7f405e Cr-Commit-Position: refs/heads/master@{#319781}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
Tom Sepez
5 years, 9 months ago (2015-03-09 22:22:31 UTC) #2
Lei Zhang
lgtm Can you add a BUG= with the aggregate bug #s from the changelist?
5 years, 9 months ago (2015-03-09 22:24:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989213003/1
5 years, 9 months ago (2015-03-09 23:22:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 23:59:06 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/608e59f9ceecd5b60ae5e50c4f0da4bc6a7f405e Cr-Commit-Position: refs/heads/master@{#319781}
5 years, 9 months ago (2015-03-10 00:00:28 UTC) #7
dgrogan
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/996523002/ by dgrogan@chromium.org. ...
5 years, 9 months ago (2015-03-10 00:09:18 UTC) #8
dgrogan
Differently broke Mac GN http://build.chromium.org/p/chromium.mac/builders/Mac%20GN/builds/4925/steps/compile/logs/stdio FAILED: /Volumes/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/pdfium/samples/pdfium_diff.image_diff.o.d -DCHROMIUM_BUILD -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -DENABLE_NOTIFICATIONS ...
5 years, 9 months ago (2015-03-10 00:17:14 UTC) #10
Tom Sepez
5 years, 9 months ago (2015-03-10 17:12:38 UTC) #11
Message was sent while issue was closed.
Crap.  Looks like my try jobs didn't actually process the roll.

Powered by Google App Engine
This is Rietveld 408576698