Issue 989203002: [x86] Faster/shorter code for stack checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 989203002: [x86] Faster/shorter code for stack checks. (Closed)

Created:
5 years, 9 months ago by Benedikt Meurer

Modified:
5 years, 9 months ago

Reviewers:
dcarney

CC:
v8-dev, Michael Starzinger

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[x86] Faster/shorter code for stack checks. Avoid loading the stack pointer and the stack limit into allocatable registers first, but generate a cmp rsp,[limit] instead. R=dcarney@chromium.org Committed: https://crrev.com/d18bfa11308ec056ca5a4ad1a7bb63fa519e37b9 Cr-Commit-Position: refs/heads/master@{#27065}

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+169 lines, -26 lines)			Patch
M	src/compiler/ia32/code-generator-ia32.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/compiler/ia32/instruction-codes-ia32.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/compiler/ia32/instruction-selector-ia32.cc	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	src/compiler/instruction-selector.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/compiler/node-matchers.h	View	2 chunks	+28 lines, -0 lines	0 comments	Download
M	src/compiler/raw-machine-assembler.h	View	4 chunks	+11 lines, -2 lines	0 comments	Download
M	src/compiler/x64/code-generator-x64.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/compiler/x64/instruction-codes-x64.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/compiler/x64/instruction-selector-x64.cc	View	9 chunks	+53 lines, -22 lines	0 comments	Download
M	test/unittests/compiler/ia32/instruction-selector-ia32-unittest.cc	View	1 chunk	+23 lines, -0 lines	0 comments	Download
M	test/unittests/compiler/x64/instruction-selector-x64-unittest.cc	View	1 chunk	+19 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

Benedikt Meurer

Committed patchset #1 (id:1) manually as d18bfa11308ec056ca5a4ad1a7bb63fa519e37b9 (presubmit successful).

5 years, 9 months ago (2015-03-09 11:06:52 UTC) #4

commit-bot: I haz the power

5 years, 9 months ago (2015-03-09 11:06:56 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d18bfa11308ec056ca5a4ad1a7bb63fa519e37b9
Cr-Commit-Position: refs/heads/master@{#27065}