Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(940)

Issue 989173005: Fixed the <webview> context menu bug. (Closed)

Created:
5 years, 9 months ago by paulmeyer
Modified:
5 years, 9 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed the <webview> context menu bug. The chrome-specific web_view event code was not fully updated during the guest_view_events refactor, resulting in the one chrome-specific event, 'contextmenu', not working properly. This patch updates that code. BUG=465194 Committed: https://crrev.com/a6da2e4352d6e0bb0496aaa2e03274c44cbb5083 Cr-Commit-Position: refs/heads/master@{#319701}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M chrome/renderer/resources/extensions/chrome_web_view.js View 2 chunks +5 lines, -8 lines 0 comments Download
M chrome/renderer/resources/extensions/chrome_web_view_experimental.js View 4 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
paulmeyer
+fsamuel@
5 years, 9 months ago (2015-03-09 16:03:43 UTC) #4
Fady Samuel
lgtm
5 years, 9 months ago (2015-03-09 16:06:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989173005/40001
5 years, 9 months ago (2015-03-09 16:07:27 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 9 months ago (2015-03-09 18:45:40 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 18:46:11 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6da2e4352d6e0bb0496aaa2e03274c44cbb5083
Cr-Commit-Position: refs/heads/master@{#319701}

Powered by Google App Engine
This is Rietveld 408576698