Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8887)

Unified Diff: chrome/renderer/resources/extensions/chrome_web_view.js

Issue 989173005: Fixed the <webview> context menu bug. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/renderer/resources/extensions/chrome_web_view_experimental.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/resources/extensions/chrome_web_view.js
diff --git a/chrome/renderer/resources/extensions/chrome_web_view.js b/chrome/renderer/resources/extensions/chrome_web_view.js
index 489a5f2cd27e3a2c72a4e91a8b7ab46dadc05083..e797f2acc0759adf8c278cb2417f81dce243014c 100644
--- a/chrome/renderer/resources/extensions/chrome_web_view.js
+++ b/chrome/renderer/resources/extensions/chrome_web_view.js
@@ -8,16 +8,13 @@ var ChromeWebView = require('chromeWebViewInternal').ChromeWebView;
var CreateEvent = require('guestViewEvents').CreateEvent;
var EventBindings = require('event_bindings');
var WebViewEvents = require('webViewEvents').WebViewEvents;
-var WebViewImpl = require('webView').WebViewImpl;
var CHROME_WEB_VIEW_EVENTS = {
'contextmenu': {
evt: CreateEvent('chromeWebViewInternal.contextmenu'),
cancelable: true,
- customHandler: function(handler, event, webViewEvent) {
- handler.webViewImpl.maybeHandleContextMenu(event, webViewEvent);
- },
- fields: ['items']
+ fields: ['items'],
+ handler: 'handleContextMenu'
}
};
@@ -27,12 +24,12 @@ var CHROME_WEB_VIEW_EVENTS = {
* This will be overridden in chrome_web_view_experimental.js to implement
* contextmenu API.
*/
-WebViewImpl.prototype.maybeHandleContextMenu = function(e, webViewEvent) {
- var requestId = e.requestId;
+WebViewEvents.prototype.handleContextMenu = function(event) {
+ var requestId = event.requestId;
// Setting |params| = undefined will show the context menu unmodified, hence
// the 'contextmenu' API is disabled for stable channel.
var params = undefined;
- ChromeWebView.showContextMenu(this.guest.getId(), requestId, params);
+ ChromeWebView.showContextMenu(this.view.guest.getId(), requestId, params);
};
// Exposes |CHROME_WEB_VIEW_EVENTS| when the ChromeWebView API is available.
« no previous file with comments | « no previous file | chrome/renderer/resources/extensions/chrome_web_view_experimental.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698