Issue 989173004: Before overapproximating the weak closure, make sure the marking deque is empty

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 989173004: Before overapproximating the weak closure, make sure the marking deque is empty (Closed)

Created:
5 years, 9 months ago by jochen (gone - plz use gerrit)

Modified:
5 years, 9 months ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Before overapproximating the weak closure, make sure the marking deque is empty Otherwise, we might miss marking a group. BUG=none R=hpayer@chromium.org LOG=n

Patch Set 2 : updates #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	src/heap/mark-compact.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Hannes Payer (out of office)

https://codereview.chromium.org/989173004/diff/1/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/989173004/diff/1/src/heap/mark-compact.cc#newcode2224 src/heap/mark-compact.cc:2224: DCHECK(marking_deque_.overflowed()); Why do we check here for overflowed?

5 years, 9 months ago (2015-03-10 13:09:28 UTC) #2

jochen (gone - plz use gerrit)

5 years, 9 months ago (2015-03-11 14:09:18 UTC) #3

On 2015/03/10 at 13:09:28, hpayer wrote:
> https://codereview.chromium.org/989173004/diff/1/src/heap/mark-compact.cc
> File src/heap/mark-compact.cc (right):
> 
>
https://codereview.chromium.org/989173004/diff/1/src/heap/mark-compact.cc#new...
> src/heap/mark-compact.cc:2224: DCHECK(marking_deque_.overflowed());
> Why do we check here for overflowed?

that's leftover code to debug where the grey objects came from. Thy come from
the polymorphic code caches and normalized map caches (filed a bug for this)

Expand Messages | Collapse Messages

Issue 989173004: Before overapproximating the weak closure, make sure the marking deque is empty (Closed)

Description

Patch Set 1 #

Patch Set 2 : updates #

Messages