Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 989173003: Fix template angle bracket syntax in css (Closed)

Created:
5 years, 9 months ago by rwlbuis
Modified:
5 years, 9 months ago
Reviewers:
rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, dglazkov+blink, ed+blinkwatch_opera.com, kenneth.christiansen, Yoav Weiss
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix template angle bracket syntax in css In C++11 the parser is able to parse >> as the end of the template argument list. BUG=449681 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191714

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -118 lines) Patch
M Source/core/css/BasicShapeFunctions.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSBasicShapes.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSFontFace.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSFontFaceSource.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSFontSelector.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSFontSelector.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSGroupingRule.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSImageGeneratorValue.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSKeyframesRule.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSPropertySourceData.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSRuleList.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSSegmentedFontFace.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSSegmentedFontFace.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSSelectorList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSSelectorList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSStyleSheet.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSValuePool.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/ElementRuleCollector.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/FontFace.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/FontFace.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/FontFaceCache.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/FontFaceSet.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/css/FontFaceSet.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/css/MediaList.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/MediaList.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/MediaQuery.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/MediaQuery.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/MediaQueryEvaluator.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/MediaQueryEvaluator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/MediaQueryList.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/MediaQueryList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/MediaQueryMatcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/MediaQueryMatcher.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/PageRuleCollector.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/PageRuleCollector.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/RuleFeature.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/RuleSet.h View 4 chunks +11 lines, -11 lines 0 comments Download
M Source/core/css/RuleSet.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/SelectorFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/StyleRule.h View 7 chunks +9 lines, -9 lines 0 comments Download
M Source/core/css/StyleRule.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/StyleRuleKeyframe.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/StyleRuleKeyframe.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/StyleSheetContents.h View 4 chunks +7 lines, -7 lines 0 comments Download
M Source/core/css/StyleSheetContents.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M Source/core/css/StyleSheetList.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/StyleSheetList.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rwlbuis
PTAL
5 years, 9 months ago (2015-03-11 14:19:27 UTC) #2
rune
lgtm since check-webkit-style actually enforces this.
5 years, 9 months ago (2015-03-11 14:51:06 UTC) #3
rwlbuis
On 2015/03/11 14:51:06, rune wrote: > lgtm since check-webkit-style actually enforces this. Thanks! Right, I ...
5 years, 9 months ago (2015-03-11 15:01:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/989173003/1
5 years, 9 months ago (2015-03-11 15:01:31 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 16:25:35 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191714

Powered by Google App Engine
This is Rietveld 408576698